Skip to content

Commit 3238360

Browse files
committed
MC-23058: Template strict mode is not set for unsaved template previews
1 parent 9a07cd0 commit 3238360

File tree

3 files changed

+50
-14
lines changed

3 files changed

+50
-14
lines changed

app/code/Magento/Email/Test/Mftf/Test/AdminEmailTemplatePreviewTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<testCaseId value="MC-15794"/>
1919
<useCaseId value="MC-11050"/>
2020
<group value="email"/>
21+
<group value="WYSIWYGDisabled"/>
2122
</annotations>
2223

2324
<before>
@@ -47,6 +48,7 @@
4748
<severity value="CRITICAL"/>
4849
<useCaseId value="MC-23058"/>
4950
<group value="email"/>
51+
<group value="WYSIWYGDisabled"/>
5052
<stories value="Email Template Preview"/>
5153
</annotations>
5254

@@ -80,6 +82,7 @@
8082
<severity value="CRITICAL"/>
8183
<useCaseId value="MC-23058"/>
8284
<group value="email"/>
85+
<group value="WYSIWYGDisabled"/>
8386
<stories value="Email Template Preview"/>
8487
</annotations>
8588

app/code/Magento/Newsletter/Test/Mftf/ActionGroup/AdminNewsletterTemplateActionGroup.xml

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,38 @@
1313
<switchToIFrame userInput="preview_iframe" stepKey="switchToIframe" />
1414
<waitForPageLoad stepKey="waitForPageLoad"/>
1515
</actionGroup>
16+
<actionGroup name="NavigateToNewsletterGrid">
17+
<amOnPage url="{{NewsletterTemplateForm.url}}" stepKey="amOnNewsletterTemplatePage"/>
18+
<waitForPageLoad stepKey="waitForNewNewsletterPageLoad"/>
19+
</actionGroup>
20+
21+
<actionGroup name="FillNewsletterForm">
22+
<arguments>
23+
<argument name="Newsletter" defaultValue="BasicFieldNewsletterSection"/>
24+
</arguments>
25+
<waitForElementVisible selector="{{BasicFieldNewsletterSection.templateName}}" stepKey="waitForTemplateNameField"/>
26+
<fillField selector="{{BasicFieldNewsletterSection.templateName}}" userInput="{{Newsletter.name}}" stepKey="fillTemplateName" />
27+
<fillField selector="{{BasicFieldNewsletterSection.templateSubject}}" userInput="{{Newsletter.subject}}" stepKey="fillTemplateSubject" />
28+
<fillField selector="{{BasicFieldNewsletterSection.senderName}}" userInput="{{Newsletter.senderName}}" stepKey="fillSenderName" />
29+
<fillField selector="{{BasicFieldNewsletterSection.senderEmail}}" userInput="{{Newsletter.senderEmail}}" stepKey="fillSenderEmail" />
30+
<fillField selector="{{BasicFieldNewsletterSection.templateText}}" userInput="{{Newsletter.templateText}}" stepKey="fillTemplateText" />
31+
</actionGroup>
32+
33+
<actionGroup name="OpenNewsletterPreviewTab">
34+
<waitForElementVisible selector="{{BasicFieldNewsletterSection.templateName}}" stepKey="waitForPreviewButton"/>
35+
<click selector="{{BasicFieldNewsletterSection.preview}}" stepKey="clickPreview"/>
36+
<switchToNextTab stepKey="switchToPreviewTab"/>
37+
<waitForPageLoad stepKey="waitForPreviewTabLoaded"/>
38+
<executeJS function="document.getElementById('preview_iframe').sandbox.add('allow-scripts')" stepKey="addSandboxValue"/>
39+
<switchToIFrame userInput="preview_iframe" stepKey="switchToIframe"/>
40+
<waitForPageLoad stepKey="waitForPreviewIframeLoaded"/>
41+
</actionGroup>
42+
43+
<actionGroup name="AssertNewsletterContent">
44+
<arguments>
45+
<argument name="Newsletter" defaultValue="BasicFieldNewsletterSection"/>
46+
</arguments>
47+
<see userInput="{{Newsletter.expectedTemplate}}" stepKey="checkTemplateContainsText"/>
48+
</actionGroup>
49+
1650
</actionGroups>

app/code/Magento/Newsletter/Test/Mftf/Test/AdminNewsletterPreviewTest.xml

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<annotations>
1212
<features value="Newsletter"/>
1313
<group value="Newsletter"/>
14+
<group value="WYSIWYGDisabled"/>
1415
<title value="Admin should be able to preview Newsletter content in draft mode"/>
1516
<description value="Admin should be able to preview newsletter content in draft mode"/>
1617
<severity value="CRITICAL"/>
@@ -26,20 +27,18 @@
2627
<actionGroup ref="logout" stepKey="logout"/>
2728
</after>
2829

29-
<!--Create a newsletter template that contains an image-->
30-
<amOnPage url="{{NewsletterTemplateForm.url}}" stepKey="amOnNewsletterTemplatePage"/>
31-
<waitForPageLoad stepKey="waitForNewNewsletterPageLoad"/>
32-
<fillField selector="{{BasicFieldNewsletterSection.templateName}}" userInput="{{NewsletterWithDirectives.name}}" stepKey="fillTemplateName" />
33-
<fillField selector="{{BasicFieldNewsletterSection.templateSubject}}" userInput="{{NewsletterWithDirectives.subject}}" stepKey="fillTemplateSubject" />
34-
<fillField selector="{{BasicFieldNewsletterSection.senderName}}" userInput="{{NewsletterWithDirectives.senderName}}" stepKey="fillSenderName" />
35-
<fillField selector="{{BasicFieldNewsletterSection.senderEmail}}" userInput="{{NewsletterWithDirectives.senderEmail}}" stepKey="fillSenderEmail" />
36-
<fillField selector="{{BasicFieldNewsletterSection.templateText}}" userInput="{{NewsletterWithDirectives.templateText}}" stepKey="fillTemplateText" />
37-
<click selector="{{BasicFieldNewsletterSection.preview}}" stepKey="clickPreview"/>
38-
<switchToNextTab stepKey="switchToPreviewTab"/>
39-
<waitForPageLoad stepKey="waitForPreviewTabLoaded"/>
40-
<switchToIFrame userInput="preview_iframe" stepKey="switchToIframe"/>
41-
<waitForPageLoad stepKey="waitForPreviewIframeLoaded"/>
42-
<see userInput="{{NewsletterWithDirectives.expectedTemplate}}" stepKey="checkTemplateContainsText"/>
30+
<actionGroup ref="NavigateToNewsletterGrid" stepKey="navigateToGrid"/>
31+
32+
<actionGroup ref="FillNewsletterForm" stepKey="fillForm">
33+
<argument name="Newsletter" value="NewsletterWithDirectives"/>
34+
</actionGroup>
35+
36+
<actionGroup ref="OpenNewsletterPreviewTab" stepKey="openPreviewTab"/>
37+
38+
<actionGroup ref="AssertNewsletterContent" stepKey="assertTemplateContent">
39+
<argument name="Newsletter" value="NewsletterWithDirectives"/>
40+
</actionGroup>
41+
4342
<closeTab stepKey="closeTab"/>
4443
</test>
4544
</tests>

0 commit comments

Comments
 (0)