Support of error pages behind a load balancer that serves HTTPS

ihor-sviziev · web-flow · commit 320c0aab8787 · 2018-10-07T08:48:28.000+03:00
Use strict comparison
diff --git a/pub/errors/processor.php b/pub/errors/processor.php
@@ -265,7 +265,7 @@ public function getHostUrl()
             $host = 'localhost';
         }
 
-        $isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] != 'off')
+        $isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] !== 'off')
             || isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && ($_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https');
         $url = ($isSecure ? 'https://' : 'http://') . $host;
 

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ public function getHostUrl()`
`265`	`265`	`$host = 'localhost';`
`266`	`266`	`}`
`267`	`267`
`268`		`- $isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] != 'off')`
	`268`	`+ $isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] !== 'off')`
`269`	`269`	`\|\| isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && ($_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https');`
`270`	`270`	`$url = ($isSecure ? 'https://' : 'http://') . $host;`
`271`	`271`