#29761: Added CreateAssetFromFileInterface

Author: sivaschenko

app/code/Magento/MediaGallerySynchronizationApi/Model/CreateAssetFromFile.php renamed to app/code/Magento/MediaGallerySynchronization/Model/CreateAssetFromFile.php

@@ -5,7 +5,7 @@
  */
 declare(strict_types=1);
 
-namespace Magento\MediaGallerySynchronizationApi\Model;
+namespace Magento\MediaGallerySynchronization\Model;
 
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Exception\FileSystemException;
@@ -15,12 +15,12 @@
 use Magento\MediaGalleryApi\Api\Data\AssetInterface;
 use Magento\MediaGalleryApi\Api\Data\AssetInterfaceFactory;
 use Magento\MediaGallerySynchronization\Model\Filesystem\GetFileInfo;
-use Magento\MediaGallerySynchronization\Model\GetContentHash;
+use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface;
 
 /**
  * Create media asset object based on the file information
  */
-class CreateAssetFromFile
+class CreateAssetFromFile implements CreateAssetFromFileInterface
 {
     /**
      * @var Filesystem
@@ -69,11 +69,7 @@ public function __construct(
     }
 
     /**
-     * Create and format media asset object
-     *
-     * @param string $path
-     * @return AssetInterface
-     * @throws FileSystemException
+     * @inheridoc
      */
     public function execute(string $path): AssetInterface
     {

app/code/Magento/MediaGallerySynchronization/Model/GetAssetFromPath.php

@@ -12,7 +12,7 @@
 use Magento\MediaGalleryApi\Api\Data\AssetInterface;
 use Magento\MediaGalleryApi\Api\Data\AssetInterfaceFactory;
 use Magento\MediaGalleryApi\Api\GetAssetsByPathsInterface;
-use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFile;
+use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface;
 
 /**
  * Create media asset object based on the file information
@@ -30,19 +30,19 @@ class GetAssetFromPath
     private $assetFactory;
 
     /**
-     * @var CreateAssetFromFile
+     * @var CreateAssetFromFileInterface
      */
     private $createAssetFromFile;
 
     /**
      * @param AssetInterfaceFactory $assetFactory
      * @param GetAssetsByPathsInterface $getMediaGalleryAssetByPath
-     * @param CreateAssetFromFile $createAssetFromFile
+     * @param CreateAssetFromFileInterface $createAssetFromFile
      */
     public function __construct(
         AssetInterfaceFactory $assetFactory,
         GetAssetsByPathsInterface $getMediaGalleryAssetByPath,
-        CreateAssetFromFile $createAssetFromFile
+        CreateAssetFromFileInterface $createAssetFromFile
     ) {
         $this->assetFactory = $assetFactory;
         $this->getAssetsByPaths = $getMediaGalleryAssetByPath;

app/code/Magento/MediaGallerySynchronization/etc/di.xml

@@ -9,6 +9,7 @@
     <preference for="Magento\MediaGallerySynchronizationApi\Api\SynchronizeInterface" type="Magento\MediaGallerySynchronization\Model\Synchronize"/>
     <preference for="Magento\MediaGallerySynchronizationApi\Model\FetchBatchesInterface" type="Magento\MediaGallerySynchronization\Model\FetchBatches"/>
     <preference for="Magento\MediaGallerySynchronizationApi\Api\SynchronizeFilesInterface" type="Magento\MediaGallerySynchronization\Model\SynchronizeFiles"/>
+    <preference for="Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface" type="Magento\MediaGallerySynchronization\Model\CreateAssetFromFile"/>
     <type name="Magento\MediaGallerySynchronizationApi\Model\ImportFilesComposite">
         <arguments>
             <argument name="importers" xsi:type="array">

app/code/Magento/MediaGallerySynchronizationApi/Model/CreateAssetFromFileInterface.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\MediaGallerySynchronizationApi\Model;
+
+use Magento\Framework\Exception\FileSystemException;
+use Magento\MediaGalleryApi\Api\Data\AssetInterface;
+
+/**
+ * Create media asset object from the media file
+ */
+interface CreateAssetFromFileInterface
+{
+    /**
+     * Create media asset object from the media file
+     *
+     * @param string $path
+     * @return AssetInterface
+     * @throws FileSystemException
+     */
+    public function execute(string $path): AssetInterface;
+}

app/code/Magento/MediaGallerySynchronizationApi/composer.json

@@ -3,7 +3,8 @@
     "description": "Magento module responsible for the media gallery synchronization implementation API",
     "require": {
         "php": "~7.3.0||~7.4.0",
-        "magento/framework": "*"
+        "magento/framework": "*",
+        "magento/module-media-gallery-api": "*"
     },
     "type": "magento2-module",
     "license": [

app/code/Magento/MediaGallerySynchronizationMetadata/Plugin/CreateAssetFromFileMetadata.php

@@ -12,7 +12,7 @@
 use Magento\MediaGalleryApi\Api\Data\AssetInterface;
 use Magento\MediaGalleryApi\Api\Data\AssetInterfaceFactory;
 use Magento\MediaGalleryMetadataApi\Api\ExtractMetadataInterface;
-use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFile;
+use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface;
 
 /**
  * Add metadata to the asset created from file
@@ -52,12 +52,12 @@ public function __construct(
     /**
      * Add metadata to the asset
      *
-     * @param CreateAssetFromFile $createAssetFromFile
+     * @param CreateAssetFromFileInterface $subject
      * @param AssetInterface $asset
      * @return AssetInterface
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterExecute(CreateAssetFromFile $createAssetFromFile, AssetInterface $asset): AssetInterface
+    public function afterExecute(CreateAssetFromFileInterface $subject, AssetInterface $asset): AssetInterface
     {
         $metadata = $this->extractMetadata->execute(
             $this->filesystem->getDirectoryRead(DirectoryList::MEDIA)->getAbsolutePath($asset->getPath())

app/code/Magento/MediaGallerySynchronizationMetadata/etc/di.xml

@@ -13,7 +13,7 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFile">
+    <type name="Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface">
         <plugin name="addMetadataToAssetCreatedFromFile" type="Magento\MediaGallerySynchronizationMetadata\Plugin\CreateAssetFromFileMetadata"/>
     </type>
 </config>