Skip to content

Commit 3149d1d

Browse files
author
Joan He
committed
Merge remote-tracking branch 'origin/MAGETWO-94438-wysiwyg-test' into BugFixPR
2 parents 9076b8d + 76fd47b commit 3149d1d

File tree

3 files changed

+38
-48
lines changed

3 files changed

+38
-48
lines changed

app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<data key="urlKey" unique="suffix">testurlkey</data>
1919
<data key="status">1</data>
2020
<data key="quantity">100</data>
21+
<data key="weight">1</data>
2122
<requiredEntity type="product_extension_attribute">EavStockItem</requiredEntity>
2223
<requiredEntity type="custom_attribute_array">CustomAttributeCategoryIds</requiredEntity>
2324
</entity>

app/code/Magento/Catalog/Test/Mftf/Section/AdminProductFormSection.xml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,24 +105,24 @@
105105
<element name="Numlist" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-bullist']" />
106106
<element name="Bullet" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-numlist']" />
107107
<element name="InsertLink" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-link']" />
108-
<element name="InsertImageIcon" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-image']" />
108+
<element name="InsertImageIcon" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-image']" timeout="30"/>
109109
<element name="InsertTable" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-table']" />
110110
<element name="SpecialCharacter" type="button" selector="//div[@id='editorproduct_form_description']//i[@class='mce-ico mce-i-charmap']" />
111-
<element name="Browse" type="button" selector=".mce-i-browse"/>
112-
<element name="BrowseUploadImage" type="file" selector=".fileupload" />
111+
<element name="Browse" type="button" selector=".mce-i-browse" timeout="30"/>
112+
<element name="BrowseUploadImage" type="file" selector=".fileupload" timeout="30"/>
113113
<element name="image" type="text" selector="//small[text()='{{var1}}']" parameterized="true"/>
114114
<element name="imageSelected" type="text" selector="//small[text()='{{var1}}']/parent::*[@class='filecnt selected']" parameterized="true"/>
115115
<element name="ImageSource" type="input" selector=".mce-combobox.mce-abs-layout-item.mce-last.mce-has-open" />
116116
<element name="ImageDescription" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-last" />
117117
<element name="Height" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-first" />
118118
<element name="UploadImage" type="file" selector=".fileupload" />
119-
<element name="OkBtn" type="button" selector="//span[text()='Ok']"/>
119+
<element name="OkBtn" type="button" selector="//button//span[text()='Ok']"/>
120120
<element name="InsertFile" type="text" selector="#insert_files" timeout="30"/>
121-
<element name="CreateFolder" type="button" selector="#new_folder" />
122-
<element name="DeleteSelectedBtn" type="text" selector="#delete_files"/>
123-
<element name="CancelBtn" type="button" selector="#cancel" />
121+
<element name="CreateFolder" type="button" selector="#new_folder" timeout="30"/>
122+
<element name="DeleteSelectedBtn" type="text" selector="#delete_files" timeout="30"/>
123+
<element name="CancelBtn" type="button" selector=".page-actions #cancel" />
124124
<element name="FolderName" type="button" selector="input[data-role='promptField']" />
125-
<element name="AcceptFolderName" type="button" selector=".action-primary.action-accept" />
125+
<element name="AcceptFolderName" type="button" selector=".action-primary.action-accept" timeout="30"/>
126126
<element name="StorageRootArrow" type="button" selector="#root > .jstree-icon" />
127127
<element name="checkIfArrowExpand" type="button" selector="//li[@id='root' and contains(@class,'jstree-closed')]" />
128128
<element name="WysiwygArrow" type="button" selector="#d3lzaXd5Zw-- > .jstree-icon" />
@@ -143,21 +143,21 @@
143143
<element name="Numlist" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-bullist']" />
144144
<element name="Bullet" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-numlist']" />
145145
<element name="InsertLink" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-link']" />
146-
<element name="InsertImageIcon" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-image']" />
146+
<element name="InsertImageIcon" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-image']" timeout="30"/>
147147
<element name="InsertTable" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-table']" />
148148
<element name="SpecialCharacter" type="button" selector="//div[@id='editorproduct_form_short_description']//i[@class='mce-ico mce-i-charmap']"/>
149149
<element name="Browse" type="button" selector=".mce-i-browse"/>
150-
<element name="BrowseUploadImage" type="file" selector=".fileupload" />
150+
<element name="BrowseUploadImage" type="file" selector=".fileupload" timeout="30" />
151151
<element name="image" type="text" selector="//small[text()='{{var1}}']" parameterized="true"/>
152152
<element name="imageSelected" type="text" selector="//small[text()='{{var1}}']/parent::*[@class='filecnt selected']" parameterized="true"/>
153153
<element name="ImageSource" type="input" selector=".mce-combobox.mce-abs-layout-item.mce-last.mce-has-open" />
154154
<element name="ImageDescription" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-last" />
155155
<element name="Height" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-first" />
156156
<element name="UploadImage" type="file" selector=".fileupload" />
157-
<element name="OkBtn" type="button" selector="//span[text()='Ok']"/>
157+
<element name="OkBtn" type="button" selector="//span[text()='Ok']" timeout="30"/>
158158
<element name="InsertFile" type="text" selector="#insert_files"/>
159159
<element name="CreateFolder" type="button" selector="#new_folder" />
160-
<element name="DeleteSelectedBtn" type="text" selector="#delete_files"/>
160+
<element name="DeleteSelectedBtn" type="text" selector="#delete_files" timeout="30"/>
161161
<element name="CancelBtn" type="button" selector="#cancel" />
162162
<element name="FolderName" type="button" selector="input[data-role='promptField']" />
163163
<element name="AcceptFolderName" type="button" selector=".action-primary.action-accept" />

app/code/Magento/Catalog/Test/Mftf/Test/AdminAddImageToWYSIWYGProductTest.xml

Lines changed: 25 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -16,82 +16,75 @@
1616
<description value="Admin should be able to add image to WYSIWYG Editor on Product Page"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-84375"/>
19-
<skip>
20-
<issueId value="MAGETWO-94438"/>
21-
</skip>
2219
</annotations>
2320
<before>
2421
<actionGroup ref="LoginActionGroup" stepKey="login"/>
2522
<actionGroup ref="EnabledWYSIWYG" stepKey="enableWYSIWYG"/>
2623
<actionGroup ref="SwitchToVersion4ActionGroup" stepKey="switchToTinyMCE4" />
2724
</before>
25+
<after>
26+
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
27+
<actionGroup ref="logout" stepKey="logout"/>
28+
</after>
29+
2830
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToNewProduct"/>
29-
<waitForPageLoad stepKey="waitForPageLoad"/>
30-
<fillField userInput="{{_defaultProduct.name}}" selector="{{AdminProductFormSection.productName}}" stepKey="fillName"/>
31-
<fillField userInput="{{_defaultProduct.price}}" selector="{{AdminProductFormSection.productPrice}}" stepKey="fillPrice"/>
32-
<fillField userInput="{{_defaultProduct.sku}}" selector="{{AdminProductFormSection.productSku}}" stepKey="fillSKU"/>
33-
<fillField userInput="{{_defaultProduct.quantity}}" selector="{{AdminProductFormSection.productQuantity}}" stepKey="fillQuantity"/>
34-
<scrollTo selector="{{AdminProductFormSection.productQuantity}}" stepKey="scrollToQty" />
31+
<waitForPageLoad stepKey="waitForPageLoadProductCreatePage"/>
32+
<actionGroup ref="fillMainProductForm" stepKey="fillBasicProductInfo" />
33+
3534
<click selector="{{AdminProductFormSection.contentTab}}" stepKey="clickContentTab" />
3635
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.TinyMCE4}}" stepKey="waitForDescription" />
3736
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.InsertImageIcon}}" stepKey="clickInsertImageIcon1" />
38-
<waitForPageLoad stepKey="waitForPageLoad1" />
3937
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.Browse}}" stepKey="clickBrowse1" />
40-
<waitForPageLoad stepKey="waitForPageLoad2" />
41-
<waitForLoadingMaskToDisappear stepKey="waitForLoading1" />
42-
<waitForLoadingMaskToDisappear stepKey="waitForLoading2" />
38+
<waitForLoadingMaskToDisappear stepKey="waitForBrowseModal" />
4339
<see selector="{{ProductDescriptionWYSIWYGToolbarSection.CancelBtn}}" userInput="Cancel" stepKey="seeCancelBtn1" />
4440
<see selector="{{ProductDescriptionWYSIWYGToolbarSection.CreateFolder}}" userInput="Create Folder" stepKey="seeCreateFolderBtn1" />
45-
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.CreateFolder}}" stepKey="createFolder1"/>
46-
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.FolderName}}" stepKey="waitForPopUp1" />
41+
<dontSeeElement selector="{{ProductDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="dontSeeAddSelectedBtn1" />
42+
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.CreateFolder}}" stepKey="createFolder1" />
43+
<waitForElement selector="{{ProductDescriptionWYSIWYGToolbarSection.FolderName}}" stepKey="waitForPopUp1" />
4744
<fillField selector="{{ProductDescriptionWYSIWYGToolbarSection.FolderName}}" userInput="{{ImageFolder.name}}" stepKey="fillFolderName1" />
4845
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.AcceptFolderName}}" stepKey="acceptFolderName11" />
49-
<waitForLoadingMaskToDisappear stepKey="waitForLoading3" />
5046
<conditionalClick selector="{{ProductDescriptionWYSIWYGToolbarSection.StorageRootArrow}}" dependentSelector="{{ProductDescriptionWYSIWYGToolbarSection.checkIfArrowExpand}}" stepKey="clickStorageRootArrowIfClosed" visible="true"/>
5147
<conditionalClick selector="{{ProductDescriptionWYSIWYGToolbarSection.WysiwygArrow}}" dependentSelector="{{ProductDescriptionWYSIWYGToolbarSection.checkIfWysiwygArrowExpand}}" stepKey="clickWysiwygArrowIfClosed" visible="true"/>
5248
<waitForText userInput="{{ImageFolder.name}}" stepKey="waitForNewFolder1" />
5349
<click userInput="{{ImageFolder.name}}" stepKey="clickOnCreatedFolder1" />
5450
<waitForLoadingMaskToDisappear stepKey="waitForLoading4" />
5551
<attachFile selector="{{ProductDescriptionWYSIWYGToolbarSection.BrowseUploadImage}}" userInput="{{ImageUpload1.value}}" stepKey="uploadImage1"/>
56-
<waitForLoadingMaskToDisappear stepKey="waitForLoading5" />
52+
<waitForLoadingMaskToDisappear stepKey="waitForFileUpload1" />
5753
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.image(ImageUpload1.value)}}" stepKey="waitForUploadImage1" />
5854
<seeElement selector="{{ProductDescriptionWYSIWYGToolbarSection.imageSelected(ImageUpload1.value)}}" stepKey="seeImageSelected1" />
5955
<see selector="{{ProductDescriptionWYSIWYGToolbarSection.DeleteSelectedBtn}}" userInput="Delete Selected" stepKey="seeDeleteBtn1"/>
6056
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.DeleteSelectedBtn}}" stepKey="clickDeleteSelected1" />
61-
<waitForText userInput="OK" stepKey="waitForConfirm1" />
62-
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.confirmDelete}}" stepKey="confirmDelete1" />
57+
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForConfirmDelete1"/>
58+
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="confirmDelete1" />
6359
<waitForElementNotVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.image(ImageUpload1.value)}}" stepKey="waitForImageDeleted1" />
6460
<dontSeeElement selector="{{ProductDescriptionWYSIWYGToolbarSection.image(ImageUpload1.value)}}" stepKey="dontSeeImage1" />
61+
<dontSeeElement selector="{{ProductDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="dontSeeAddSelectedBtn2" />
6562
<attachFile selector="{{ProductDescriptionWYSIWYGToolbarSection.BrowseUploadImage}}" userInput="{{ImageUpload1.value}}" stepKey="uploadImage2"/>
66-
<waitForLoadingMaskToDisappear stepKey="waitForLoading6" />
63+
<waitForLoadingMaskToDisappear stepKey="waitForFileUpload2" />
6764
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.image(ImageUpload1.value)}}" stepKey="waitForUploadImage2" />
6865
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="clickInsertBtn1" />
69-
<waitForLoadingMaskToDisappear stepKey="waitForLoading7" />
70-
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.OkBtn}}" stepKey="waitForOkBtn1" />
66+
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.ImageDescription}}" stepKey="waitForImageDescriptionButton1" />
7167
<fillField selector="{{ProductDescriptionWYSIWYGToolbarSection.ImageDescription}}" userInput="{{ImageUpload1.content}}" stepKey="fillImageDescription1" />
7268
<fillField selector="{{ProductDescriptionWYSIWYGToolbarSection.Height}}" userInput="{{ImageUpload1.height}}" stepKey="fillImageHeight1" />
7369
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.OkBtn}}" stepKey="clickOkBtn1" />
74-
<waitForPageLoad stepKey="waitForPageLoad3"/>
7570
<scrollTo selector="{{ProductDescriptionWYSIWYGToolbarSection.TinyMCE4}}" stepKey="scrollToTinyMCE4" />
7671
<click selector="{{ProductShortDescriptionWYSIWYGToolbarSection.InsertImageIcon}}" stepKey="clickInsertImageIcon2" />
77-
<waitForPageLoad stepKey="waitForPageLoad4" />
7872
<click selector="{{ProductShortDescriptionWYSIWYGToolbarSection.Browse}}" stepKey="clickBrowse2" />
79-
<waitForPageLoad stepKey="waitForPageLoad5" />
80-
<waitForLoadingMaskToDisappear stepKey="waitForLoading8" />
73+
<waitForElementVisible selector="{{ProductDescriptionWYSIWYGToolbarSection.CancelBtn}}" stepKey="waitForCancelButton2"/>
8174
<see selector="{{ProductShortDescriptionWYSIWYGToolbarSection.CancelBtn}}" userInput="Cancel" stepKey="seeCancelBtn2" />
8275
<see selector="{{ProductShortDescriptionWYSIWYGToolbarSection.CreateFolder}}" userInput="Create Folder" stepKey="seeCreateFolderBtn2" />
83-
<dontSeeElement selector="{{ProductShortDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="dontSeeAddSelectedBtn2" />
76+
<dontSeeElement selector="{{ProductShortDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="dontSeeAddSelectedBtn3" />
8477
<attachFile selector="{{ProductShortDescriptionWYSIWYGToolbarSection.BrowseUploadImage}}" userInput="{{ImageUpload3.value}}" stepKey="uploadImage3"/>
78+
<waitForLoadingMaskToDisappear stepKey="waitForFileUpload3" />
8579
<waitForElementVisible selector="{{ProductShortDescriptionWYSIWYGToolbarSection.image(ImageUpload3.value)}}" stepKey="waitForUploadImage3" />
86-
<waitForLoadingMaskToDisappear stepKey="waitForLoading9" />
87-
<wait time="3" stepKey="waitMore" />
8880
<waitForElement selector="{{ProductShortDescriptionWYSIWYGToolbarSection.DeleteSelectedBtn}}" stepKey="waitForDeletebtn" />
8981
<see selector="{{ProductShortDescriptionWYSIWYGToolbarSection.DeleteSelectedBtn}}" userInput="Delete Selected" stepKey="seeDeleteBtn2"/>
9082
<click selector="{{ProductShortDescriptionWYSIWYGToolbarSection.DeleteSelectedBtn}}" stepKey="clickDeleteSelected2" />
91-
<waitForText userInput="OK" stepKey="waitForConfirm3" />
92-
<click selector="{{ProductShortDescriptionWYSIWYGToolbarSection.confirmDelete}}" stepKey="confirmDelete2" />
83+
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForConfirm3"/>
84+
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="confirmDelete2" />
85+
<dontSeeElement selector="{{ProductDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="dontSeeAddSelectedBtn4" />
9386
<attachFile selector="{{ProductShortDescriptionWYSIWYGToolbarSection.BrowseUploadImage}}" userInput="{{ImageUpload3.value}}" stepKey="uploadImage4"/>
94-
<waitForLoadingMaskToDisappear stepKey="waitForLoading10" />
87+
<waitForLoadingMaskToDisappear stepKey="waitForFileUpload4" />
9588
<waitForElementVisible selector="{{ProductShortDescriptionWYSIWYGToolbarSection.image(ImageUpload3.value)}}" stepKey="waitForUploadImage4" />
9689
<click selector="{{ProductShortDescriptionWYSIWYGToolbarSection.InsertFile}}" stepKey="clickInsertBtn" />
9790
<waitForLoadingMaskToDisappear stepKey="waitForLoading11" />
@@ -107,9 +100,5 @@
107100
<seeElement selector="{{StorefrontProductInfoMainSection.mediaDescription}}" stepKey="assertMediaDescription"/>
108101
<seeElementInDOM selector="{{StorefrontCategoryMainSection.imageSource(ImageUpload3.fileName)}}" stepKey="assertMediaSource3"/>
109102
<seeElementInDOM selector="{{StorefrontCategoryMainSection.imageSource(ImageUpload1.fileName)}}" stepKey="assertMediaSource1"/>
110-
<after>
111-
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
112-
<actionGroup ref="logout" stepKey="logout"/>
113-
</after>
114103
</test>
115104
</tests>

0 commit comments

Comments
 (0)