Skip to content

Commit 30822ef

Browse files
committed
Refactoring the construct to have an optionally dependency instead a required one
1 parent 128724f commit 30822ef

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

app/code/Magento/Backend/Block/Media/Uploader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function __construct(
5959
) {
6060
$this->_fileSizeService = $fileSize;
6161
$this->jsonEncoder = $jsonEncoder ?: ObjectManager::getInstance()->get(Json::class);
62-
$this->imageConfig = $imageConfig ?: ObjectManager::getInstance()->get(ConfigInterface::class);
62+
$this->imageConfig = $imageConfig ?: ObjectManager::getInstance()->get(ConfigInterface::class);;
6363

6464
parent::__construct($context, $data);
6565
}

app/code/Magento/Cms/Block/Adminhtml/Wysiwyg/Images/Content/Uploader.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,17 @@ class Uploader extends \Magento\Backend\Block\Media\Uploader
2323
/**
2424
* @param \Magento\Backend\Block\Template\Context $context
2525
* @param \Magento\Framework\File\Size $fileSize
26-
* @param \Magento\Framework\Image\Adapter\ConfigInterface $imageConfig
2726
* @param \Magento\Cms\Model\Wysiwyg\Images\Storage $imagesStorage
2827
* @param array $data
2928
*/
3029
public function __construct(
3130
\Magento\Backend\Block\Template\Context $context,
3231
\Magento\Framework\File\Size $fileSize,
33-
\Magento\Framework\Image\Adapter\ConfigInterface $imageConfig,
3432
\Magento\Cms\Model\Wysiwyg\Images\Storage $imagesStorage,
3533
array $data = []
3634
) {
3735
$this->_imagesStorage = $imagesStorage;
38-
parent::__construct($context, $fileSize, $imageConfig, $data);
36+
parent::__construct($context, $fileSize, $data);
3937
}
4038

4139
/**

app/code/Magento/Theme/Block/Adminhtml/Wysiwyg/Files/Content/Uploader.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,18 @@ class Uploader extends \Magento\Backend\Block\Media\Uploader
3131
/**
3232
* @param \Magento\Backend\Block\Template\Context $context
3333
* @param \Magento\Framework\File\Size $fileSize
34-
* @param \Magento\Framework\Image\Adapter\ConfigInterface $imageConfig
3534
* @param \Magento\Theme\Helper\Storage $storageHelper
3635
* @param array $data
3736
*/
3837
public function __construct(
3938
\Magento\Backend\Block\Template\Context $context,
4039
\Magento\Framework\File\Size $fileSize,
41-
\Magento\Framework\Image\Adapter\ConfigInterface $imageConfig,
4240
\Magento\Theme\Helper\Storage $storageHelper,
4341
array $data = []
4442
) {
4543
$this->_storageHelper = $storageHelper;
4644

47-
parent::__construct($context, $fileSize, $imageConfig, $data);
45+
parent::__construct($context, $fileSize, $data);
4846
}
4947

5048
/**

0 commit comments

Comments
 (0)