ACP2E-783: [Cloud] Mistyped search term does not result in accurate Search suggestions/corrections

Author: dhorytskyi

app/code/Magento/Elasticsearch/Model/DataProvider/Base/Suggestions.php

@@ -158,7 +158,6 @@ public function isResultsCountEnabled()
      * Get Suggestions
      *
      * @param QueryInterface $query
-     *
      * @return array
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
@@ -180,7 +179,7 @@ private function getSuggestions(QueryInterface $query)
                     }
                 }
             }
-            ksort($suggestions);
+            krsort($suggestions);
             $texts = array_unique(array_column($suggestions, 'text'));
             $suggestions = array_slice(
                 array_intersect_key(array_values($suggestions), $texts),
@@ -195,12 +194,11 @@ private function getSuggestions(QueryInterface $query)
     /**
      * Init Search Query
      *
-     * @param string $query
-     *
+     * @param QueryInterface $query
      * @return array
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
-    private function initQuery($query)
+    private function initQuery(QueryInterface $query): array
     {
         $searchQuery = [
             'index' => $this->searchIndexNameResolver->getIndexName(
@@ -235,7 +233,7 @@ private function addSuggestFields($searchQuery, $searchSuggestionsCount)
                     'field' => $field,
                     'analyzer' => 'standard',
                     'size' => $searchSuggestionsCount,
-                    'max_errors' => 1,
+                    'max_errors' => 0.9,
                     'direct_generator' => [
                         [
                             'field' => $field,

dev/tests/integration/testsuite/Magento/AdvancedSearch/Model/SuggestedQueriesTest.php

@@ -0,0 +1,43 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\AdvancedSearch\Model;
+
+use Magento\Search\Model\Query;
+use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
+
+class SuggestedQueriesTest extends TestCase
+{
+    /**
+     * @var SuggestedQueries
+     */
+    private $suggestedQueries;
+
+    protected function setUp(): void
+    {
+        $this->suggestedQueries = Bootstrap::getObjectManager()
+            ->create(SuggestedQueries::class);
+    }
+
+    /**
+     * @magentoDataFixture Magento\Catalog\Test\Fixture\Product with:{"name":"fresh arugula salad"}
+     * @magentoConfigFixture current_store catalog/search/search_suggestion_count 8
+     */
+    public function testGetItems(): void
+    {
+        $query = Bootstrap::getObjectManager()
+            ->create(Query::class, ['data' => ['query_text' => 'frshe arugul salat']]);
+        $queryResults = $this->suggestedQueries->getItems($query);
+        $queryTexts = [];
+        foreach ($queryResults as $queryResult) {
+            $queryTexts[] = $queryResult->getQueryText();
+        }
+        self::assertCount(7, $queryTexts);
+        self::assertEquals('fresh arugula salad', $queryTexts[0]);
+    }
+}