Code Review changes to Customer module

Author: lbajsarowicz

app/code/Magento/Customer/Model/Plugin/CustomerNotification.php

@@ -69,14 +69,14 @@ public function __construct(
         State $state,
         CustomerRepositoryInterface $customerRepository,
         LoggerInterface $logger,
-        RequestInterface $request = null
+        RequestInterface $request
     ) {
         $this->session = $session;
         $this->notificationStorage = $notificationStorage;
         $this->state = $state;
         $this->customerRepository = $customerRepository;
         $this->logger = $logger;
-        $this->request = $request ?? ObjectManager::getInstance()->get(RequestInterface::class);
+        $this->request = $request;
     }
 
     /**

app/code/Magento/Customer/Model/Visitor.php

@@ -38,7 +38,7 @@ class Visitor extends AbstractModel
     const VISITOR_TYPE_VISITOR = 'v';
     const DEFAULT_ONLINE_MINUTES_INTERVAL = 15;
     const XML_PATH_ONLINE_INTERVAL = 'customer/online_customers/online_minutes_interval';
-    const SECONDS_24_HOURS = 86400;
+    private const SECONDS_24_HOURS = 86400;
 
     /**
      * @var string[]
@@ -129,7 +129,7 @@ public function __construct(
         $this->scopeConfig = $scopeConfig;
         $this->dateTime = $dateTime;
         $this->indexerRegistry = $indexerRegistry;
-        $this->requestSafety = $requestSafety ?? ObjectManager::getInstance()->create(RequestSafetyInterface::class);
+        $this->requestSafety = $requestSafety ?? ObjectManager::getInstance()->get(RequestSafetyInterface::class);
     }
 
     /**

app/code/Magento/Customer/Test/Unit/Model/Plugin/CustomerNotificationTest.php

@@ -112,6 +112,10 @@ public function testBeforeExecute()
             ->method('remove')
             ->with(NotificationStorage::UPDATE_CUSTOMER_SESSION, self::STUB_CUSTOMER_ID);
 
+        $this->sessionMock->expects($this->once())->method('setCustomerData')->with($customerMock);
+        $this->sessionMock->expects($this->once())->method('setCustomerGroupId')->with($customerGroupId);
+        $this->sessionMock->expects($this->once())->method('regenerateId');
+
         $this->plugin->beforeExecute($this->actionMock);
     }