Skip to content

Commit 2fad6d0

Browse files
committed
MAGETWO-39619: Broken layout for shipping checkout step.Blank Theme
1 parent 2b81885 commit 2fad6d0

File tree

6 files changed

+19
-14
lines changed

6 files changed

+19
-14
lines changed

app/code/Magento/Checkout/view/frontend/web/template/shipping.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* See COPYING.txt for license details.
55
*/
66
-->
7-
<li id="opc-shipping" data-bind="fadeVisible: visible()">
7+
<li id="opc-shipping" class="checkout-shipping-address" data-bind="fadeVisible: visible()">
88
<div class="step-title" data-bind="text: $t('Shipping Address')" data-role="title"></div>
99
<div id="checkout-step-shipping"
1010
class="step-content"
@@ -48,7 +48,10 @@
4848

4949

5050
<!--Shipping method template-->
51-
<li id="opc-shipping_method" data-bind="fadeVisible: visible(), blockLoader: isLoading" role="presentation">
51+
<li id="opc-shipping_method"
52+
class="checkout-shipping-method"
53+
data-bind="fadeVisible: visible(), blockLoader: isLoading"
54+
role="presentation">
5255
<div class="checkout-shipping-method">
5356
<div class="step-title" data-bind="text: $t('Shipping Methods')" data-role="title"></div>
5457
<!-- ko foreach: getRegion('before-shipping-method-form') -->

app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_checkout.less

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@
1313
@checkout-step-title__border: @border-width__base solid @color-gray80;
1414
@checkout-step-title__font-size: 26px;
1515
@checkout-step-title__font-weight: @font-weight__light;
16-
@checkout-step-title__margin-bottom: 28px;
1716
@checkout-step-title__padding: @indent__s;
1817

1918
@checkout-step-title-mobile__font-size: 18px;
20-
@checkout-step-title-mobile__margin-bottom: @indent__base;
2119

2220
//
2321
// Common
@@ -39,7 +37,6 @@
3937

4038
.step-title {
4139
&:extend(.abs-checkout-title all);
42-
.css(margin, 0 0 @checkout-step-title__margin-bottom);
4340
}
4441

4542
.step-content {
@@ -66,7 +63,6 @@
6663
.opc-wrapper {
6764
.step-title {
6865
.css(font-size, @checkout-step-title-mobile__font-size);
69-
.css(margin-bottom, @checkout-step-title-mobile__margin-bottom);
7066
border-bottom: 0;
7167
padding-bottom: 0;
7268
}

app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_shipping.less

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
// _____________________________________________
99

1010
@checkout-shipping-address__max-width: 600px;
11+
@checkout-shipping-address__margin-top: 28px;
1112

1213
@checkout-shipping-item-icon__background-color: @checkout-shipping-item__active__border-color;
1314
@checkout-shipping-item-icon__color: @color-white;
@@ -50,6 +51,7 @@
5051

5152
.form-login,
5253
.form-shipping-address {
54+
.css(margin-top, @checkout-shipping-address__margin-top);
5355
margin-bottom: @indent__base;
5456

5557
.fieldset {
@@ -204,6 +206,7 @@
204206
.css(margin, @checkout-shipping-item-mobile__padding);
205207
.css(padding, @checkout-shipping-item-mobile__padding);
206208
}
209+
207210
.shipping-address-item {
208211
.css(border-bottom, 1px solid @checkout-shipping-item-before__border-color);
209212
.css(margin, @checkout-shipping-item-mobile__margin);
@@ -219,6 +222,11 @@
219222
}
220223
}
221224

225+
.form-login,
226+
.form-shipping-address {
227+
.css(margin-top, @checkout-shipping-address__margin-top);
228+
}
229+
222230
.action-select-shipping-item {
223231
float: none;
224232
margin-top: @indent__s;

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_checkout.less

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@
1313
@checkout-step-title__border: @border-width__base solid @color-gray80;
1414
@checkout-step-title__font-size: 26px;
1515
@checkout-step-title__font-weight: @font-weight__light;
16-
@checkout-step-title__margin-bottom: 28px;
1716
@checkout-step-title__padding: @indent__s;
1817

1918
@checkout-step-title-mobile__font-size: 18px;
20-
@checkout-step-title-mobile__margin-bottom: @indent__base;
2119

2220
@checkout-step-content-mobile__background: @color-gray-light01;
2321
@checkout-step-content-mobile__margin-s: 15px;
24-
@checkout-step-content-mobile__margin: 0 -(@checkout-step-content-mobile__margin-s) @checkout-step-content-mobile__margin-s;
22+
@checkout-step-content-mobile__margin: @indent__base -(@checkout-step-content-mobile__margin-s) @checkout-step-content-mobile__margin-s;
2523

2624
//
2725
// Common
@@ -44,7 +42,6 @@
4442
.step-title {
4543
&:extend(.abs-checkout-title all);
4644
.css(border-bottom, @checkout-step-title__border);
47-
.css(margin, 0 0 @checkout-step-title__margin-bottom);
4845
}
4946

5047
.step-content {
@@ -71,7 +68,6 @@
7168
.opc-wrapper {
7269
.step-title {
7370
.css(font-size, @checkout-step-title-mobile__font-size);
74-
.css(margin-bottom, @checkout-step-title-mobile__margin-bottom);
7571
border-bottom: 0;
7672
padding-bottom: 0;
7773
}

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_order-summary.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
> .title {
165165
border-bottom: 0;
166166
.css(font-size, @checkout-step-title-mobile__font-size);
167-
.css(margin-bottom, @checkout-step-title-mobile__margin-bottom);
167+
margin-bottom: @indent__base;
168168
padding-bottom: 0;
169169
}
170170
.totals {

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_shipping.less

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
// _____________________________________________
99

1010
@checkout-shipping-address__max-width: 500px;
11+
@checkout-shipping-address__margin-top: 28px;
1112

1213
@checkout-shipping-item-icon__background-color: @checkout-shipping-item__active__border-color;
1314
@checkout-shipping-item-icon__color: @color-white;
@@ -50,7 +51,8 @@
5051

5152
.form-login,
5253
.form-shipping-address {
53-
.css(margin-bottom, @checkout-step-title__margin-bottom);
54+
.css(margin-top, @checkout-shipping-address__margin-top);
55+
.css(margin-bottom, @checkout-shipping-address__margin-top);
5456
.fieldset {
5557
.field {
5658
.label {
@@ -292,7 +294,7 @@
292294

293295
.form-login {
294296
.css(border-bottom, @checkout-step-title__border);
295-
.css(padding-bottom, @checkout-step-title__margin-bottom);
297+
padding-bottom: @indent__base;
296298
}
297299
}
298300
.table-checkout-shipping-method {

0 commit comments

Comments
 (0)