ENGCOM-7605: Remove redundant argument in method useProductItem #28466

Author: slavvka

app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php

@@ -149,7 +149,7 @@ public function getItems()
             $this->_compareProduct->setAllowUsedFlat(false);
 
             $this->_items = $this->_itemCollectionFactory->create();
-            $this->_items->useProductItem(true)->setStoreId($this->_storeManager->getStore()->getId());
+            $this->_items->useProductItem()->setStoreId($this->_storeManager->getStore()->getId());
 
             if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
                 $this->_items->setCustomerId($this->currentCustomer->getCustomerId());

app/code/Magento/Catalog/Helper/Product/Compare.php

@@ -279,7 +279,7 @@ public function getItemCollection()
             // cannot be placed in constructor because of the cyclic dependency which cannot be fixed with proxy class
             // collection uses this helper in constructor when calling isEnabledFlat() method
             $this->_itemCollection = $this->_itemCollectionFactory->create();
-            $this->_itemCollection->useProductItem(true)->setStoreId($this->_storeManager->getStore()->getId());
+            $this->_itemCollection->useProductItem()->setStoreId($this->_storeManager->getStore()->getId());
 
             if ($this->_customerSession->isLoggedIn()) {
                 $this->_itemCollection->setCustomerId($this->_customerSession->getCustomerId());
@@ -313,7 +313,7 @@ public function calculate($logout = false)
     {
         /** @var $collection Collection */
         $collection = $this->_itemCollectionFactory->create()
-            ->useProductItem(true);
+            ->useProductItem();
         if (!$logout && $this->_customerSession->isLoggedIn()) {
             $collection->setCustomerId($this->_customerSession->getCustomerId());
         } elseif ($this->_customerId) {

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Compared.php

@@ -46,23 +46,15 @@ public function getItemCollection()
         $collection = $this->getData('item_collection');
         if ($collection === null) {
             if ($collection = $this->getCreateOrderModel()->getCustomerCompareList()) {
-                $collection = $collection->getItemCollection()->useProductItem(
-                    true
-                )->setStoreId(
-                    $this->getQuote()->getStoreId()
-                )->addStoreFilter(
-                    $this->getQuote()->getStoreId()
-                )->setCustomerId(
-                    $this->getCustomerId()
-                )->addAttributeToSelect(
-                    'name'
-                )->addAttributeToSelect(
-                    'price'
-                )->addAttributeToSelect(
-                    'image'
-                )->addAttributeToSelect(
-                    'status'
-                )->load();
+                $collection = $collection->getItemCollection()
+                    ->useProductItem()
+                    ->setStoreId($this->getQuote()->getStoreId())
+                    ->addStoreFilter($this->getQuote()->getStoreId())
+                    ->setCustomerId($this->getCustomerId())
+                    ->addAttributeToSelect('name')
+                    ->addAttributeToSelect('price')->addAttributeToSelect('image')
+                    ->addAttributeToSelect('status')
+                    ->load();
             }
             $this->setData('item_collection', $collection);
         }

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Pcompared.php

@@ -89,13 +89,11 @@ public function getItemCollection()
             // get products to skip
             $skipProducts = [];
             if ($collection = $this->getCreateOrderModel()->getCustomerCompareList()) {
-                $collection = $collection->getItemCollection()->useProductItem(
-                    true
-                )->setStoreId(
-                    $this->getStoreId()
-                )->setCustomerId(
-                    $this->getCustomerId()
-                )->load();
+                $collection = $collection->getItemCollection()
+                    ->useProductItem()
+                    ->setStoreId($this->getStoreId())
+                    ->setCustomerId($this->getCustomerId())
+                    ->load();
                 foreach ($collection as $_item) {
                     $skipProducts[] = $_item->getProductId();
                 }

dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php

@@ -412,7 +412,7 @@ protected function _assertCompareListEquals(array $expectedProductIds)
         $compareItems = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
             \Magento\Catalog\Model\ResourceModel\Product\Compare\Item\Collection::class
         );
-        $compareItems->useProductItem(true);
+        $compareItems->useProductItem();
         // important
         $compareItems->setVisitorId(
             \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(