🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #14481: Parameter update for post method in http client interface (by @simpleadm)
 - #14460: [Forwardport] Disable "Back" button on the first step of the setup (by @mastiuhin-olexandr)
 - #14453: [ForwardPort 2.3-develop] Remove else statements from \Magento\Framework\Session\SessionManager (by @adrian-martinez-interactiv4)
 - #14437: [Forwardport] Disable add to cart button when redirect to cart enabled (by @mastiuhin-olexandr)


Fixed GitHub Issues:
 - #3489: CURL Json POST (reported by @Grohotun) has been fixed in #14481 by @simpleadm in 2.3-develop branch
   Related commits:
     1. 1f3cc4d

 - #14307: Possible to press the "Previous" button while in the first step of the installation (reported by @ArjenMiedema) has been fixed in #14460 by @mastiuhin-olexandr in 2.3-develop branch
   Related commits:
     1. 14f5227
     2. 1214c4f

Author: magento-engcom-team

app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml

@@ -40,22 +40,10 @@
     </div>
 </div>
 <?php endif; ?>
-<?php if ($block->isRedirectToCartEnabled()) : ?>
-<script type="text/x-magento-init">
-    {
-        "#product_addtocart_form": {
-            "Magento_Catalog/product/view/validation": {
-                "radioCheckboxClosest": ".nested"
-            }
-        }
-    }
-</script>
-<?php else : ?>
 <script type="text/x-magento-init">
     {
         "#product_addtocart_form": {
             "Magento_Catalog/js/validate-product": {}
         }
     }
 </script>
-<?php endif; ?>

lib/internal/Magento/Framework/HTTP/ClientInterface.php

@@ -99,7 +99,7 @@ public function get($uri);
      * Make POST request
      *
      * @param string $uri full uri
-     * @param array $params POST fields array
+     * @param array|string $params POST fields array or string in case of JSON or XML data
      * @return void
      */
     public function post($uri, $params);

lib/internal/Magento/Framework/Session/SessionManager.php

@@ -317,11 +317,8 @@ public function setName($name)
      */
     public function destroy(array $options = null)
     {
-        if (null === $options) {
-            $options = $this->defaultDestroyOptions;
-        } else {
-            $options = array_merge($this->defaultDestroyOptions, $options);
-        }
+        $options = $options ?? [];
+        $options = array_merge($this->defaultDestroyOptions, $options);
 
         if ($options['clear_storage']) {
             $this->clearStorage();
@@ -504,11 +501,7 @@ public function regenerateId()
             return $this;
         }
 
-        if ($this->isSessionExists()) {
-            session_regenerate_id(true);
-        } else {
-            session_start();
-        }
+        $this->isSessionExists() ? session_regenerate_id(true) : session_start();
         $this->storage->init(isset($_SESSION) ? $_SESSION : []);
 
         if ($this->sessionConfig->getUseCookies()) {

setup/pub/magento/setup/main.js

@@ -93,10 +93,6 @@ main.controller('navigationController',
             return str.indexOf(suffix, str.length - suffix.length) !== -1;
         };
 
-        $scope.goToStart = function() {
-            $scope.goToAction($state.current.type);
-        };
-
         $scope.goToBackup = function() {
             $state.go('root.create-backup-uninstall');
         };

setup/view/magento/setup/readiness-check.phtml

@@ -18,7 +18,7 @@
             <button
                 type="button"
                 class="btn"
-                ng-click="goToStart()"
+                disabled="disabled"
                 >Back</button>
         </div>
         <div class="btn-wrap btn-wrap-try-again"