MAGETWO-60442: Add optional SerializerInterface dependency to child classes of \Magento\Framework\Config\Data

Adding class and __constructor descriptions

Author: Igor Melnikov

dev/tests/integration/etc/install-config-mysql.php.dist

@@ -7,7 +7,7 @@
 return [
     'db-host' => 'localhost',
     'db-user' => 'root',
-    'db-password' => 'vagrant',
+    'db-password' => '123123q',
     'db-name' => 'magento_integration_tests',
     'db-prefix' => '',
     'backend-frontname' => 'backend',

lib/internal/Magento/Framework/App/ResourceConnection/Config.php

@@ -21,6 +21,8 @@ class Config extends \Magento\Framework\Config\Data\Scoped implements ConfigInte
     protected $_connectionNames = [];
 
     /**
+     * Constructor
+     *
      * @param Config\Reader $reader
      * @param \Magento\Framework\Config\ScopeInterface $configScope
      * @param \Magento\Framework\Config\CacheInterface $cache

lib/internal/Magento/Framework/Config/Data.php

@@ -68,7 +68,7 @@ class Data implements \Magento\Framework\Config\DataInterface
     /**
      * @var SerializerInterface
      */
-    protected $serializer;
+    private $serializer;
 
     /**
      * Constructor

lib/internal/Magento/Framework/Config/Data/Scoped.php

@@ -55,6 +55,11 @@ class Scoped extends \Magento\Framework\Config\Data
      */
     protected $_loadedScopes = [];
 
+    /**
+     * @var SerializerInterface
+     */
+    private $serializer;
+
     /**
      * Constructor
      *

lib/internal/Magento/Framework/Interception/PluginList/PluginList.php

@@ -82,6 +82,11 @@ class PluginList extends Scoped implements InterceptionPluginList
      */
     private $logger;
 
+    /**
+     * @var SerializerInterface
+     */
+    private $serializer;
+
     /**
      * Constructor
      *
@@ -111,8 +116,8 @@ public function __construct(
         $cacheId = 'plugins',
         SerializerInterface $serializer = null
     ) {
-        $serializer = $serializer ?: $objectManager->get(Serialize::class);
-        parent::__construct($reader, $configScope, $cache, $cacheId, $serializer);
+        $this->serializer = $serializer ?: $objectManager->get(Serialize::class);
+        parent::__construct($reader, $configScope, $cache, $cacheId, $this->serializer);
         $this->_omConfig = $omConfig;
         $this->_relations = $relations;
         $this->_definitions = $definitions;