Skip to content

Commit 2e22a25

Browse files
committed
MC-5777: Catalog rule does not apply as expected
- Unskip tests
1 parent 60271a7 commit 2e22a25

File tree

8 files changed

+6
-34
lines changed

8 files changed

+6
-34
lines changed

app/code/Magento/Catalog/Model/Api/SearchCriteria/CollectionProcessor/ConditionProcessor/ConditionBuilder/EavAttributeCondition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function build(Filter $filter): string
6464
->select()
6565
->from(
6666
[Collection::MAIN_TABLE_ALIAS => $entityResourceModel->getEntityTable()],
67-
Collection::MAIN_TABLE_ALIAS . '.' . $entityResourceModel->getEntityIdField()
67+
Collection::MAIN_TABLE_ALIAS . '.' . $entityResourceModel->getLinkField()
6868
)->joinLeft(
6969
[$tableAlias => $attribute->getBackendTable()],
7070
$tableAlias . '.' . $attribute->getEntityIdField() . '=' . Collection::MAIN_TABLE_ALIAS .

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminApplyCatalogRuleByCategoryTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
<severity value="MAJOR"/>
1717
<testCaseId value="MC-74"/>
1818
<group value="CatalogRule"/>
19-
<skip>
20-
<issueId value="MC-5777"/>
21-
</skip>
2219
</annotations>
2320
<before>
2421
<createData entity="ApiCategory" stepKey="createCategoryOne"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminCreateCatalogPriceRuleTest.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<severity value="MAJOR"/>
1818
<testCaseId value="MC-65"/>
1919
<group value="CatalogRule"/>
20-
<skip>
21-
<issueId value="MC-5777"/>
22-
</skip>
2320
</annotations>
2421
<before>
2522
<!-- Create the simple product and category that it will be in -->
@@ -77,9 +74,6 @@
7774
<severity value="MAJOR"/>
7875
<testCaseId value="MC-93"/>
7976
<group value="CatalogRule"/>
80-
<skip>
81-
<issueId value="MC-5777"/>
82-
</skip>
8377
</annotations>
8478
<before>
8579
<actionGroup stepKey="createNewPriceRule" ref="newCatalogPriceRuleByUI">
@@ -103,9 +97,6 @@
10397
<severity value="MAJOR"/>
10498
<testCaseId value="MC-69"/>
10599
<group value="CatalogRule"/>
106-
<skip>
107-
<issueId value="MC-5777"/>
108-
</skip>
109100
</annotations>
110101
<before>
111102
<actionGroup stepKey="createNewPriceRule" ref="newCatalogPriceRuleByUI">
@@ -129,9 +120,6 @@
129120
<severity value="MAJOR"/>
130121
<testCaseId value="MC-60"/>
131122
<group value="CatalogRule"/>
132-
<skip>
133-
<issueId value="MC-5777"/>
134-
</skip>
135123
</annotations>
136124
<before>
137125
<actionGroup stepKey="createNewPriceRule" ref="newCatalogPriceRuleByUI">
@@ -155,9 +143,6 @@
155143
<severity value="MAJOR"/>
156144
<testCaseId value="MC-71"/>
157145
<group value="CatalogRule"/>
158-
<skip>
159-
<issueId value="MC-5777"/>
160-
</skip>
161146
</annotations>
162147
<before>
163148
<!-- Create a simple product and a category-->

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminDeleteCatalogPriceRuleTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<severity value="MAJOR"/>
1818
<testCaseId value="MC-160"/>
1919
<group value="CatalogRule"/>
20-
<skip>
21-
<issueId value="MC-5777"/>
22-
</skip>
2320
</annotations>
2421
<before>
2522
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminEnableAttributeIsUndefinedCatalogPriceRuleTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@
6363
<deleteData createDataKey="createSecondProductAttribute" stepKey="deleteSecondProductAttribute"/>
6464

6565
<actionGroup ref="logout" stepKey="logout"/>
66+
<magentoCLI command="indexer:reindex" stepKey="reindex"/>
67+
<magentoCLI command="cache:flush" stepKey="flushCache"/>
6668
</after>
6769

6870
<!--Create catalog price rule-->

app/code/Magento/CatalogRule/Test/Mftf/Test/CatalogPriceRuleAndCustomerGroupMembershipArePersistedUnderLongTermCookieTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-69455"/>
1919
<group value="persistent"/>
20-
<skip>
21-
<issueId value="MC-5777"/>
22-
</skip>
2320
</annotations>
2421
<before>
2522
<createData entity="PersistentConfigEnabled" stepKey="enablePersistent"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/StorefrontInactiveCatalogRuleTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MC-79"/>
1919
<group value="CatalogRule"/>
20-
<skip>
21-
<issueId value="MC-5777"/>
22-
</skip>
2320
</annotations>
2421
<before>
2522
<actionGroup ref="LoginAsAdmin" stepKey="login"/>

app/code/Magento/ConfigurableProduct/Test/Mftf/Test/StorefrontSortingByPriceForConfigurableWithCatalogRuleAppliedTest.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
<description value="Sort by price should be correct if the apply Catalog Rule to child product of configurable product"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-69988"/>
19-
<skip>
20-
<issueId value="MC-5777"/>
21-
</skip>
2219
<group value="сonfigurable_product"/>
2320
</annotations>
2421
<before>
@@ -153,9 +150,9 @@
153150
<argument name="sortBy" value="price"/>
154151
<argument name="sort" value="desc"/>
155152
</actionGroup>
156-
<see selector="{{StorefrontCategoryMainSection.lineProductName('1')}}" userInput="$$createConfigProduct.name$$" stepKey="seeConfigurableProduct2"/>
157-
<see selector="{{StorefrontCategoryMainSection.lineProductName('2')}}" userInput="$$createSimpleProduct2.name$$" stepKey="seeSimpleProductTwo2"/>
158-
<see selector="{{StorefrontCategoryMainSection.lineProductName('3')}}" userInput="$$createSimpleProduct.name$$" stepKey="seeSimpleProduct2"/>
153+
<see selector="{{StorefrontCategoryMainSection.lineProductName('1')}}" userInput="$$createSimpleProduct2.name$$" stepKey="seeSimpleProductTwo2"/>
154+
<see selector="{{StorefrontCategoryMainSection.lineProductName('2')}}" userInput="$$createSimpleProduct.name$$" stepKey="seeSimpleProduct2"/>
155+
<see selector="{{StorefrontCategoryMainSection.lineProductName('3')}}" userInput="$$createConfigProduct.name$$" stepKey="seeConfigurableProduct2"/>
159156

160157
<!-- Delete the rule -->
161158
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage"/>

0 commit comments

Comments
 (0)