Skip to content

Commit 2e000c4

Browse files
committed
MAGETWO-83094: Products Orderd Report exported CSV is empty
1 parent 33abbe8 commit 2e000c4

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

dev/tests/integration/testsuite/Magento/Backend/Model/UrlTest.php

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,37 @@ public function testGetUrl()
4444
$url = $this->_model->getUrl('adminhtml/auth/login');
4545
$this->assertContains('admin/auth/login/key/', $url);
4646

47-
$this->request->setParams(['param' => 'ab==']);
47+
$routeParams = [
48+
'_escape_params' => false,
49+
'param1' => 'a1=='
50+
];
51+
$url = $this->_model->getUrl('path', $routeParams);
52+
$this->assertContains('/param1/a1==/', $url);
53+
54+
$this->request->setParams(['param2' => 'a2==']);
4855
$routeParams = [
4956
'_current' => true,
50-
'_escape_params' => true,
57+
'_escape_params' => false,
5158
];
5259
$url = $this->_model->getUrl('path', $routeParams);
60+
$this->assertContains('/param2/a2==/', $url);
61+
5362
/** @var ParamEncoder $paramEncoder */
5463
$paramEncoder = Bootstrap::getObjectManager()->get(ParamEncoder::class);
55-
$this->assertContains('/param/' . $paramEncoder->encode('ab==') . '/', $url);
64+
$routeParams = [
65+
'_escape_params' => true,
66+
'param3' => 'a3=='
67+
];
68+
$url = $this->_model->getUrl('path', $routeParams);
69+
$this->assertContains('/param3/' . $paramEncoder->encode('a3==') . '/', $url);
70+
71+
$this->request->setParams(['param4' => 'a4==']);
72+
$routeParams = [
73+
'_current' => true,
74+
'_escape_params' => true,
75+
];
76+
$url = $this->_model->getUrl('path', $routeParams);
77+
$this->assertContains('/param4/' . $paramEncoder->encode('a4==') . '/', $url);
5678
}
5779

5880
/**

dev/tests/integration/testsuite/Magento/Customer/Controller/Adminhtml/IndexTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,14 @@ public function testSaveActionWithValidCustomerDataAndValidAddressData()
217217
$this->assertNotEquals(0, $this->accountManagement->getDefaultBillingAddress($customerId));
218218
$this->assertNull($this->accountManagement->getDefaultShippingAddress($customerId));
219219

220+
$urlPatternParts = [
221+
$this->_baseControllerUrl . 'edit',
222+
'id/' . $customerId,
223+
'back/1',
224+
];
225+
$urlPattern = '/^' . str_replace('/', '\/', implode('(/.*/)|/', $urlPatternParts)) . '/';
220226
$this->assertRedirect(
221-
$this->stringStartsWith($this->_baseControllerUrl . 'edit/id/' . $customerId . '/back/1')
227+
$this->matchesRegularExpression($urlPattern)
222228
);
223229

224230
/** @var \Magento\Newsletter\Model\Subscriber $subscriber */

0 commit comments

Comments
 (0)