ENGCOM-4750: Adding a validation before adding or executing layout generator class. #22324

Author: sidolov

lib/internal/Magento/Framework/View/Layout/GeneratorPool.php

@@ -37,7 +37,7 @@ class GeneratorPool
      * @param ScheduledStructure\Helper $helper
      * @param ConditionFactory $conditionFactory
      * @param \Psr\Log\LoggerInterface $logger
-     * @param array $generators
+     * @param array|null $generators
      */
     public function __construct(
         ScheduledStructure\Helper $helper,
@@ -67,7 +67,7 @@ public function getGenerator($type)
     }
 
     /**
-     * Traverse through all generators and generate all scheduled elements
+     * Traverse through all generators and generate all scheduled elements.
      *
      * @param Reader\Context $readerContext
      * @param Generator\Context $generatorContext
@@ -86,11 +86,17 @@ public function process(Reader\Context $readerContext, Generator\Context $genera
      * Add generators to pool
      *
      * @param GeneratorInterface[] $generators
+     *
      * @return void
      */
     protected function addGenerators(array $generators)
     {
         foreach ($generators as $generator) {
+            if (!$generator instanceof GeneratorInterface) {
+                throw new \InvalidArgumentException(
+                    sprintf('Generator class must be an instance of %s', GeneratorInterface::class)
+                );
+            }
             $this->generators[$generator->getType()] = $generator;
         }
     }
@@ -131,9 +137,9 @@ protected function buildStructure(ScheduledStructure $scheduledStructure, Data\S
     }
 
     /**
-     * Reorder a child of a specified element
+     * Reorder a child of a specified element.
      *
-     * @param ScheduledStructure $scheduledStructure,
+     * @param ScheduledStructure $scheduledStructure
      * @param Data\Structure $structure
      * @param string $elementName
      * @return void
@@ -227,6 +233,8 @@ protected function moveElementInStructure(
     }
 
     /**
+     * Check visibility conditions exists in data.
+     *
      * @param array $data
      *
      * @return bool