MAGETWO-93978: Footer Overlaps Storefront Page Content In Mobile View

Devagouda Patil · Devagouda Patil · commit 2cba91293595 · 2018-08-27T23:48:02.000-05:00
- Review comments incorporated for Function test
diff --git a/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml b/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml
@@ -83,7 +83,7 @@
     <entity name="_longContentCmsPage" type="cms_page">
         <data key="title">Test CMS Page</data>
         <data key="content_heading">Test Content Heading</data>
-        <data key="content">Sample long page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.</data>
+        <data key="content">1&lt;br/&gt;2&lt;br/&gt;3&lt;br/&gt;4&lt;br/&gt;5&lt;br/&gt;6&lt;br/&gt;7&lt;br/&gt;8&lt;br/&gt;9&lt;br/&gt;10&lt;br/&gt;11&lt;br/&gt;12&lt;br/&gt;13&lt;br/&gt;14&lt;br/&gt;15&lt;br/&gt;16&lt;br/&gt;17&lt;br/&gt;18&lt;br/&gt;19&lt;br/&gt;20&lt;br/&gt;line21&lt;br/&gt;22&lt;br/&gt;23&lt;br/&gt;24&lt;br/&gt;25&lt;br/&gt;26&lt;br/&gt;line27&lt;br/&gt;2&lt;br/&gt;3&lt;br/&gt;4&lt;br/&gt;5</data>
         <data key="identifier" unique="suffix">test-page-</data>
     </entity>
 </entities>
diff --git a/app/code/Magento/Cms/Test/Mftf/Section/StorefrontCMSPageSection.xml b/app/code/Magento/Cms/Test/Mftf/Section/StorefrontCMSPageSection.xml
@@ -13,8 +13,6 @@
         <element name="imageSource" type="text" selector="//img[contains(@src,'{{var1}}')]" parameterized="true"/>
         <element name="mainTitle" type="text" selector="#maincontent .page-title"/>
         <element name="mainContent" type="text" selector="#maincontent"/>
-    </section>
-    <section name="StorefrontCMSPageFooterSection">
-        <element name="footerSection" type="text" selector="footer.page-footer"/>
+        <element name="footerTop" type="text" selector="footer.page-footer"/>
     </section>
 </sections>
diff --git a/app/code/Magento/Cms/Test/Mftf/Test/StoreFrontMobileViewValidation.xml b/app/code/Magento/Cms/Test/Mftf/Test/StoreFrontMobileViewValidation.xml
@@ -28,15 +28,15 @@
         <resizeWindow width="375" height="812" stepKey="resizeWindowToMobile"/>
         <amOnPage url="$$createPreReqCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
         <waitForPageLoad stepKey="waitForPageLoad6" />
-        <!-- Verifying that Footer is not in visible area by default as the CMS page has lots of content which will occupy entire visible area-->
-        <executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="topOfFooter"/>
+         <!--Verifying that Footer is not in visible area by default as the CMS page has lots of content which will occupy entire visible area-->
+        <executeJS function="return document.querySelector('{{StorefrontCMSPageSection.footerTop}}').getBoundingClientRect().top" stepKey="topOfFooter"/>
         <assertGreaterThan stepKey="assertDefaultLoad">
             <actualResult type="variable">topOfFooter</actualResult>
             <expectedResult type="string">812</expectedResult>
         </assertGreaterThan>
-        <!-- Verifying that even after scroll footer section is below the main content section -->
-        <scrollTo selector="{{StorefrontCMSPageFooterSection.footerSection}}" stepKey="scrollToFooterSection"/>
-        <executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="topOfTheFooterAfterScroll"/>
+         <!--Verifying that even after scroll footer section is below the main content section-->
+        <scrollTo selector="{{StorefrontCMSPageSection.footerTop}}" stepKey="scrollToFooterSection"/>
+        <executeJS function="return document.querySelector('{{StorefrontCMSPageSection.footerTop}}').getBoundingClientRect().top" stepKey="topOfTheFooterAfterScroll"/>
         <executeJS function="return document.querySelector('{{StorefrontCMSPageSection.mainContent}}').getBoundingClientRect().bottom" stepKey="bottomOfMainContent"/>
         <assertGreaterThan stepKey="assertAfterScroll">
             <actualResult type="variable">topOfTheFooterAfterScroll</actualResult>
