Skip to content

Commit 2b679c1

Browse files
committed
MAGETWO-63444: Remove object from cache in \Magento\Theme\Model\Theme\ThemeProvider
- Fix string concat spacing. Add long description to getThemeById docblock.
1 parent 210250e commit 2b679c1

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

app/code/Magento/Theme/Model/Theme/ThemeProvider.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function getThemeByFullPath($fullPath)
8383
return $this->getThemeList()->getThemeByFullPath($fullPath);
8484
}
8585

86-
$theme = $this->loadThemeFromCache('theme'. $fullPath);
86+
$theme = $this->loadThemeFromCache('theme' . $fullPath);
8787
if ($theme) {
8888
$this->themes[$fullPath] = $theme;
8989
return $theme;
@@ -113,6 +113,10 @@ public function getThemeCustomizations(
113113
}
114114

115115
/**
116+
* Get theme by id
117+
*
118+
* Checks local object cache first, application cache second, and will fall back on creating and loading
119+
* a new Theme object. Loaded Theme is only cached by ID, as virtual themes may have matching base paths.
116120
* {@inheritdoc}
117121
*/
118122
public function getThemeById($themeId)

0 commit comments

Comments
 (0)