Skip to content

Commit 2a5a1b3

Browse files
committed
ACP2E-64: Bundle Products Special Price Column in Grid should have % sign not currency sign
- Fixed the CR comments.
1 parent 6af0b5d commit 2a5a1b3

File tree

2 files changed

+13
-18
lines changed

2 files changed

+13
-18
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<!--
3-
/**
4-
* Copyright © Magento, Inc. All rights reserved.
5-
* See COPYING.txt for license details.
6-
*/
7-
-->
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
@@ -13,12 +13,16 @@
1313
<description>Assert special price attribute value from the catalog product grid page</description>
1414
</annotations>
1515
<arguments>
16+
<argument name="specialPriceColumn" type="string"/>
1617
<argument name="expectedValue" type="string"/>
17-
<argument name="actualValue" type="string"/>
1818
</arguments>
19+
<!-- Check the special price column are present in catalog product grid -->
20+
<seeElement selector="{{AdminProductGridSection.columnHeader(specialPriceColumn)}}" stepKey="seeSpecialPriceColumn"/>
21+
<!-- Grab the special price value from the catalog product grid -->
22+
<grabTextFrom selector="{{AdminProductGridSection.productGridCell('1', specialPriceColumn)}}" stepKey="getSpecialPrice"/>
1923
<assertStringContainsString stepKey="assertSpecialPricePercentageSymbol">
2024
<expectedResult type="string">{{expectedValue}}</expectedResult>
21-
<actualResult type="variable">{{actualValue}}</actualResult>
25+
<actualResult type="variable">$getSpecialPrice</actualResult>
2226
</assertStringContainsString>
2327
</actionGroup>
2428
</actionGroups>
Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
<after>
2929
<!-- Navigate to catalog product index page -->
3030
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="navigateToProductIndexPage"/>
31-
<!-- Clear all the search filter -->
32-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAll"/>
3331
<!-- Set product grid to default columns -->
3432
<actionGroup ref="ResetProductGridToDefaultViewActionGroup" stepKey="setProductGridToDefaultColumns"/>
3533
<!-- Open the column dropdown to reset the default columns from the catalog product grid -->
@@ -76,8 +74,6 @@
7674
<actionGroup ref="ResetAdminProductGridColumnsActionGroup" stepKey="resetAdminProductGridColumns"/>
7775
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="closeColumnsDropdownAfterReset"/>
7876

79-
<!-- Check the special price attribute column is present or not -->
80-
<dontSeeElement selector="{{AdminProductGridSection.columnHeader('Special Price')}}" stepKey="dontSeeSpecialPriceColumn"/>
8177
<!-- Open the column dropdown to add the special price from the catalog product grid -->
8278
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="openColumnsDropdownSpecialPrice"/>
8379
<actionGroup ref="CheckAdminProductGridColumnOptionActionGroup" stepKey="checkSpecialPriceOption">
@@ -90,15 +86,10 @@
9086
<argument name="sku" value="{{BundleProduct.sku}}"/>
9187
</actionGroup>
9288

93-
<!-- Check the special price column are present in catalog product grid -->
94-
<seeElement selector="{{AdminProductGridSection.columnHeader('Special Price')}}" stepKey="seeSpecialPriceColumn"/>
95-
<!-- Grab the special price value from the catalog product grid -->
96-
<grabTextFrom selector="{{AdminProductGridSection.productGridCell('1', 'Special Price')}}" stepKey="getSpecialPrice"/>
97-
9889
<!-- Asserting with the special price value contains the percentage value -->
9990
<actionGroup ref="AdminAssertSpecialPriceAttributeValueOnProductGridPageActionGroup" stepKey="assertSpecialPricePercentageSymbol">
91+
<argument name="specialPriceColumn" value="Special Price"/>
10092
<argument name="expectedValue" value="90.00%"/>
101-
<argument name="actualValue" value="$getSpecialPrice"/>
10293
</actionGroup>
10394
</test>
10495
</tests>

0 commit comments

Comments
 (0)