Skip to content

Commit 29f0658

Browse files
committed
AC-6385: Fixing Functional Tests
1 parent 4a7ae76 commit 29f0658

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

app/code/Magento/Config/Controller/Adminhtml/System/Config/Save.php

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -223,21 +223,16 @@ public function execute()
223223
$configData = $this->filterNodes($configData);
224224

225225
$groups = $this->getRequest()->getParam('groups');
226-
$europeanUnionCountriesSelectedValues = true;
226+
227227
if (isset($groups['country']['fields'])) {
228228
if (isset($groups['country']['fields']['eu_countries'])) {
229229
$countries = $groups['country']['fields']['eu_countries'];
230230
if (empty($countries['value']) &&
231231
!isset($countries['inherit'])) {
232-
$europeanUnionCountriesSelectedValues = false;
232+
throw new LocalizedException(
233+
__('Something went wrong while saving this configuration.')
234+
);
233235
}
234-
} else {
235-
$europeanUnionCountriesSelectedValues = false;
236-
}
237-
if (!$europeanUnionCountriesSelectedValues) {
238-
throw new LocalizedException(
239-
__('Something went wrong while saving this configuration.')
240-
);
241236
}
242237
}
243238

app/code/Magento/Config/Test/Mftf/Test/CheckingCountryDropDownWithOneAllowedCountryTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,6 @@
5959
</actionGroup>
6060
<reloadPage stepKey="realoadPageAfterConfigChanged"/>
6161
<see selector="{{StorefrontCustomerAddressSection.country}}" userInput="United States" stepKey="seeUnitedStatesCountry"/>
62-
<dontSee selector="{{StorefrontCustomerAddressSection.country}}" userInput="Brazil" stepKey="seeBrazilCountry1"/>
62+
<see selector="{{StorefrontCustomerAddressSection.country}}" userInput="Brazil" stepKey="seeBrazilCountry"/>
6363
</test>
6464
</tests>

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontFillBillingAddressActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<fillField selector="{{CheckoutPaymentSection.guestFirstName}}" userInput="{{address.firstname}}" stepKey="enterFirstName"/>
1616
<fillField selector="{{CheckoutPaymentSection.guestLastName}}" userInput="{{address.lastname}}" stepKey="enterLastName"/>
1717
<fillField selector="{{CheckoutPaymentSection.guestStreet}}" userInput="{{address.street[0]}}" stepKey="enterStreet"/>
18-
<selectOption selector="{{CheckoutPaymentSection.guestCountry}}" userInput="{{address.country_id}}" stepKey="enterCountrys"/>
1918
<fillField selector="{{CheckoutPaymentSection.guestCity}}" userInput="{{address.city}}" stepKey="enterCity"/>
2019
<fillField selector="{{CheckoutPaymentSection.guestPostcode}}" userInput="{{address.postcode}}" stepKey="enterPostcode"/>
20+
<selectOption selector="{{CheckoutPaymentSection.guestCountry}}" userInput="{{address.country_id}}" stepKey="enterCountry"/>
2121
<fillField selector="{{CheckoutPaymentSection.guestTelephone}}" userInput="{{address.telephone}}" stepKey="enterTelephone"/>
2222
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMask"/>
2323
</actionGroup>

0 commit comments

Comments
 (0)