BUG#AC-1285: Buttons with duplicate labels fixed on Product landing page, add/edit product, add/edit page, add/edit block

Author: glo80326

app/code/Magento/Backend/Block/Widget/Button/SplitButton.php

@@ -168,7 +168,7 @@ public function getToggleAttributesHtml()
             'title' => $title,
             'class' => join(' ', $classes),
             'disabled' => $disabled,
-            'aria-label' => $this->getData('dropDownAriaLabel') ?: '',
+            'aria-label' => $this->getData('dropdown_button_aria_label') ?: '',
         ];
         $this->_getDataAttributes(['mage-init' => '{"dropdown": {}}', 'toggle' => 'dropdown'], $attributes);
 

app/code/Magento/Catalog/Block/Adminhtml/Product.php

@@ -59,7 +59,7 @@ protected function _prepareLayout()
             'button_class' => '',
             'class_name' => \Magento\Backend\Block\Widget\Button\SplitButton::class,
             'options' => $this->_getAddProductButtonOptions(),
-            'dropDownAriaLabel' => 'Add product of type'
+            'dropdown_button_aria_label' => __('Add product of type'),
         ];
         $this->buttonList->add('add_new', $addButtonProps);
 

app/code/Magento/Cms/Block/Adminhtml/Block/Edit/SaveButton.php

@@ -40,7 +40,7 @@ public function getButtonData()
             ],
             'class_name' => Container::SPLIT_BUTTON,
             'options' => $this->getOptions(),
-            'dropDownAriaLabel' => 'Save options',
+            'dropdown_button_aria_label' => __('Save options'),
         ];
     }
 

app/code/Magento/Cms/Block/Adminhtml/Page/Edit/SaveButton.php

@@ -38,7 +38,7 @@ public function getButtonData()
             'class_name' => Container::SPLIT_BUTTON,
             'options' => $this->getOptions(),
             'sort_order' => 90,
-            'dropDownAriaLabel' => 'Save options',
+            'dropdown_button_aria_label' => __('Save options'),
         ];
     }
 

app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Button/Save.php

@@ -40,7 +40,7 @@ public function getButtonData()
             ],
             'class_name' => Container::SPLIT_BUTTON,
             'options' => $this->getOptions(),
-            'dropDownAriaLabel' => 'Save options',
+            'dropdown_button_aria_label' => __('Save options'),
         ];
     }
 

app/code/Magento/Ui/Component/Control/SplitButton.php

@@ -165,7 +165,7 @@ public function getToggleAttributesHtml()
             'title' => $title,
             'class' => join(' ', $classes),
             'disabled' => $disabled,
-            'aria-label' => $this->getData('dropDownAriaLabel') ?: '',
+            'aria-label' => $this->getData('dropdown_button_aria_label') ?: '',
         ];
         $this->getDataAttributes(['mage-init' => '{"dropdown": {}}', 'toggle' => 'dropdown'], $attributes);