Skip to content

Commit 290dbf7

Browse files
author
Partica, Cristian
committed
MAGETWO-44290: Translations.json file is not cached on client side
- moved some dependency to just be required once
1 parent 0b1cc43 commit 290dbf7

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

app/code/Magento/Translation/view/base/templates/translate.phtml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,29 +11,25 @@
1111
require.config({
1212
deps: [
1313
'jquery',
14+
'mage/translate',
1415
'jquery/jquery-storageapi'
1516
],
1617
callback: function ($) {
1718
'use strict';
1819

19-
var dependencies,
20-
timeout;
20+
var dependencies = [],
21+
versionObj;
2122

2223
$.initNamespaceStorage('mage-translation-storage');
2324
$.initNamespaceStorage('mage-translation-file-version');
24-
timeout = $.localStorage.get('mage-translation-file-version');
25+
versionObj = $.localStorage.get('mage-translation-file-version');
2526

26-
if (timeout.version !== '<?php /* @escapeNotVerified */
27+
if (versionObj.version !== '<?php /* @escapeNotVerified */
2728
echo sha1($block->getTranslationFileTimestamp() . $block->getTranslationFilePath()) ?>') {
28-
dependencies = [
29-
'text!<?php /* @escapeNotVerified */ echo Magento\Translation\Model\Js\Config::DICTIONARY_FILE_NAME?>',
30-
'mage/translate'
31-
];
29+
dependencies.push(
30+
'text!<?php /* @escapeNotVerified */ echo Magento\Translation\Model\Js\Config::DICTIONARY_FILE_NAME?>'
31+
);
3232

33-
} else {
34-
dependencies = [
35-
'mage/translate'
36-
];
3733
}
3834

3935
require.config({

0 commit comments

Comments
 (0)