Skip to content

Commit 28d72fa

Browse files
MAGETWO-94407: [2.3.0] Cart Price Rule for configurable products
- Fix static test
1 parent 1946914 commit 28d72fa

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

app/code/Magento/SalesRule/Model/Rule/Condition/Product.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ private function getAttributeScopeElement()
118118
/**
119119
* Set attribute value
120120
*
121-
* @param $value
121+
* @param string $value
122122
*/
123123
public function setAttribute($value)
124124
{
@@ -213,6 +213,8 @@ public function getValueElementChooserUrl()
213213
}
214214

215215
/**
216+
* Get formatted price.
217+
*
216218
* @param string $value
217219
* @return float|null
218220
*/

app/code/Magento/SalesRule/Model/Rule/Condition/Product/Combine.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use Magento\Catalog\Model\ResourceModel\Product\Collection;
99

1010
/**
11+
* Combine conditions for product.
1112
* @api
1213
* @since 100.0.2
1314
*/
@@ -114,6 +115,8 @@ protected function _isValid($entity)
114115
}
115116

116117
/**
118+
* Validate entity.
119+
*
117120
* @param object $cond
118121
* @param \Magento\Framework\Model\AbstractModel $entity
119122
* @return bool
@@ -135,7 +138,7 @@ private function validateEntity($cond, \Magento\Framework\Model\AbstractModel $e
135138
/**
136139
* Retrieve entities for validation by attribute scope
137140
*
138-
* @param $attributeScope
141+
* @param string $attributeScope
139142
* @param \Magento\Framework\Model\AbstractModel $entity
140143
* @return \Magento\Framework\Model\AbstractModel[]
141144
*/

0 commit comments

Comments
 (0)