MAGETWO-37843: All responsive email templates in Blank Theme

- removed unused constructor param
- other minor fixes

Author: David Alger

app/code/Magento/Customer/Model/AccountManagement.php

@@ -14,10 +14,12 @@
 use Magento\Customer\Api\CustomerRepositoryInterface;
 use Magento\Customer\Api\Data\AddressInterface;
 use Magento\Customer\Api\Data\CustomerInterface;
+use Magento\Customer\Api\Data\ValidationResultsInterfaceFactory;
 use Magento\Customer\Helper\View as CustomerViewHelper;
 use Magento\Customer\Model\Config\Share as ConfigShare;
 use Magento\Customer\Model\Customer as CustomerModel;
 use Magento\Customer\Model\Metadata\Validator;
+use Magento\Framework\Api\ExtensibleDataObjectConverter;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\Encryption\EncryptorInterface as Encryptor;
 use Magento\Framework\Event\ManagerInterface;
@@ -30,6 +32,8 @@
 use Magento\Framework\Exception\State\ExpiredException;
 use Magento\Framework\Exception\State\InputMismatchException;
 use Magento\Framework\Exception\State\InvalidTransitionException;
+use Magento\Framework\ObjectFactory;
+use Magento\Framework\Registry;
 use Psr\Log\LoggerInterface as PsrLogger;
 use Magento\Framework\Exception\MailException;
 use Magento\Framework\Mail\Template\TransportBuilder;
@@ -205,11 +209,10 @@ class AccountManagement implements AccountManagementInterface
      * @param StoreManagerInterface $storeManager
      * @param Random $mathRandom
      * @param Validator $validator
-     * @param \Magento\Customer\Api\Data\ValidationResultsInterfaceFactory $validationResultsDataFactory
+     * @param ValidationResultsInterfaceFactory $validationResultsDataFactory
      * @param AddressRepositoryInterface $addressRepository
      * @param CustomerMetadataInterface $customerMetadataService
      * @param CustomerRegistry $customerRegistry
-     * @param \Magento\Framework\Url $url
      * @param PsrLogger $logger
      * @param Encryptor $encryptor
      * @param ConfigShare $configShare
@@ -218,12 +221,12 @@ class AccountManagement implements AccountManagementInterface
      * @param ScopeConfigInterface $scopeConfig
      * @param TransportBuilder $transportBuilder
      * @param DataObjectProcessor $dataProcessor
-     * @param \Magento\Framework\Registry $registry
+     * @param Registry $registry
      * @param CustomerViewHelper $customerViewHelper
      * @param DateTime $dateTime
      * @param CustomerModel $customerModel
-     * @param \Magento\Framework\ObjectFactory $objectFactory
-     * @param \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter
+     * @param ObjectFactory $objectFactory
+     * @param ExtensibleDataObjectConverter $extensibleDataObjectConverter
      *
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
@@ -233,11 +236,10 @@ public function __construct(
         StoreManagerInterface $storeManager,
         Random $mathRandom,
         Validator $validator,
-        \Magento\Customer\Api\Data\ValidationResultsInterfaceFactory $validationResultsDataFactory,
+        ValidationResultsInterfaceFactory $validationResultsDataFactory,
         AddressRepositoryInterface $addressRepository,
         CustomerMetadataInterface $customerMetadataService,
         CustomerRegistry $customerRegistry,
-        \Magento\Framework\Url $url,
         PsrLogger $logger,
         Encryptor $encryptor,
         ConfigShare $configShare,
@@ -246,12 +248,12 @@ public function __construct(
         ScopeConfigInterface $scopeConfig,
         TransportBuilder $transportBuilder,
         DataObjectProcessor $dataProcessor,
-        \Magento\Framework\Registry $registry,
+        Registry $registry,
         CustomerViewHelper $customerViewHelper,
         DateTime $dateTime,
         CustomerModel $customerModel,
-        \Magento\Framework\ObjectFactory $objectFactory,
-        \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter
+        ObjectFactory $objectFactory,
+        ExtensibleDataObjectConverter $extensibleDataObjectConverter
     ) {
         $this->customerFactory = $customerFactory;
         $this->eventManager = $eventManager;
@@ -614,18 +616,19 @@ public function changePasswordById($customerId, $currentPassword, $newPassword)
     /**
      * Change customer password.
      *
-     * @param string $email
+     * @param CustomerModel $customer
      * @param string $currentPassword
      * @param string $newPassword
      * @return bool true on success
+     * @throws InputException
+     * @throws InvalidEmailOrPasswordException
      */
     private function changePasswordForCustomer($customer, $currentPassword, $newPassword)
     {
         $customerSecure = $this->customerRegistry->retrieveSecureData($customer->getId());
         $hash = $customerSecure->getPasswordHash();
         if (!$this->encryptor->validateHash($currentPassword, $hash)) {
-            throw new InvalidEmailOrPasswordException(
-                __('The password doesn\'t match this account.'));
+            throw new InvalidEmailOrPasswordException(__('The password doesn\'t match this account.'));
         }
         $customerSecure->setRpToken(null);
         $customerSecure->setRpTokenCreatedAt(null);