Code review

ilnytskyi · ilnytskyi · commit 268b1ba86dc2 · 2020-01-17T13:41:52.000+01:00
diff --git a/lib/web/mage/translate.js b/lib/web/mage/translate.js
@@ -38,7 +38,7 @@ define([
                      * @return {String}
                      */
                     translate: function (text) {
-                        return _data.hasOwnProperty(text) ? _data[text] : text;
+                        return typeof _data[text] !== 'undefined' ? _data[text] : text;
                     }
                 };
             }())

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ define([`
`38`	`38`	`* @return {String}`
`39`	`39`	`*/`
`40`	`40`	`translate: function (text) {`
`41`		`- return _data.hasOwnProperty(text) ? _data[text] : text;`
	`41`	`+ return typeof _data[text] !== 'undefined' ? _data[text] : text;`
`42`	`42`	`}`
`43`	`43`	`};`
`44`	`44`	`}())`