MAGETWO-64260: [Optimize] Performance for grouped products with large # of options

nikshostko · nikshostko · commit 266c55250024 · 2019-04-16T14:20:14.000+03:00
- Fix static test;
diff --git a/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php b/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php
@@ -475,10 +475,12 @@ public function hasWeight()
      * @param \Magento\Catalog\Model\Product $product
      * @return void
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * phpcs:disable Magento2.CodeAnalysis.EmptyBlock
      */
     public function deleteTypeSpecificData(\Magento\Catalog\Model\Product $product)
     {
     }
+    //phpcs:enable
 
     /**
      * @inheritdoc
@@ -488,6 +490,7 @@ public function beforeSave($product)
         //clear cached associated links
         $product->unsetData($this->_keyAssociatedProducts);
         if ($product->hasData('product_options') && !empty($product->getData('product_options'))) {
+            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('Custom options for grouped product type are not supported');
         }
         return parent::beforeSave($product);

Original file line number	Diff line number	Diff line change
`@@ -475,10 +475,12 @@ public function hasWeight()`
`475`	`475`	`* @param \Magento\Catalog\Model\Product $product`
`476`	`476`	`* @return void`
`477`	`477`	`* @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`478`	`+ * phpcs:disable Magento2.CodeAnalysis.EmptyBlock`
`478`	`479`	`*/`
`479`	`480`	`public function deleteTypeSpecificData(\Magento\Catalog\Model\Product $product)`
`480`	`481`	`{`
`481`	`482`	`}`
	`483`	`+ //phpcs:enable`
`482`	`484`
`483`	`485`	`/**`
`484`	`486`	`* @inheritdoc`
`@@ -488,6 +490,7 @@ public function beforeSave($product)`
`488`	`490`	`//clear cached associated links`
`489`	`491`	`$product->unsetData($this->_keyAssociatedProducts);`
`490`	`492`	`if ($product->hasData('product_options') && !empty($product->getData('product_options'))) {`
	`493`	`+ //phpcs:ignore Magento2.Exceptions.DirectThrow`
`491`	`494`	`throw new \Exception('Custom options for grouped product type are not supported');`
`492`	`495`	`}`
`493`	`496`	`return parent::beforeSave($product);`