MC-21811: Canonical_url displays the backend domain instead of relative

- added test for category canonical_url

Author: dthampy

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoryCanonicalUrlTest.php

@@ -0,0 +1,89 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\GraphQl\Catalog;
+
+use Magento\Catalog\Model\ResourceModel\Category\Collection as CategoryCollection;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
+use Magento\TestFramework\TestCase\GraphQlAbstract;
+use Magento\Catalog\Api\Data\CategoryInterface;
+
+/**
+ * Test for getting canonical url data from category
+ */
+class CategoryCanonicalUrlTest extends GraphQlAbstract
+{
+    /** @var ObjectManager $objectManager */
+    private $objectManager;
+
+    /**
+     * @magentoApiDataFixture Magento/Catalog/_files/categories.php
+     * @magentoConfigFixture default_store catalog/seo/category_canonical_tag 1
+     */
+    public function testCategoryWithCanonicalLinksMetaTagSettingsEnabled()
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+        /** @var CategoryCollection $categoryCollection */
+        $categoryCollection = $this->objectManager->create(CategoryCollection::class);
+        $categoryCollection->addFieldToFilter('name', 'Category 1.1.1');
+        /** @var CategoryInterface $category */
+        $category = $categoryCollection->getFirstItem();
+        $categoryId = $category->getId();
+        $query = <<<QUERY
+    {
+categoryList(filters: {ids: {in: ["$categoryId"]}}) {
+    id
+    name
+   url_key
+   url_suffix
+   canonical_url
+ }
+}
+QUERY;
+
+        $response = $this->graphQlQuery($query);
+        $this->assertNotEmpty($response['categoryList'], 'Category list should not be empty');
+        $this->assertEquals('.html', $response['categoryList'][0]['url_suffix']);
+        $this->assertEquals(
+            'category-1/category-1-1/category-1-1-1.html',
+            $response['categoryList'][0]['canonical_url']
+        );
+    }
+
+    /**
+     * @magentoApiDataFixture Magento/Catalog/_files/categories.php
+     * @magentoConfigFixture default_store catalog/seo/category_canonical_tag 0
+     */
+    public function testCategoryWithCanonicalLinksMetaTagSettingsDisabled()
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+        /** @var CategoryCollection $categoryCollection */
+        $categoryCollection = $this->objectManager->create(CategoryCollection::class);
+        $categoryCollection->addFieldToFilter('name', 'Category 1.1');
+        /** @var CategoryInterface $category */
+        $category = $categoryCollection->getFirstItem();
+        $categoryId = $category->getId();
+        $query = <<<QUERY
+    {
+categoryList(filters: {ids: {in: ["$categoryId"]}}) {
+    id
+    name
+   url_key
+   canonical_url
+ }
+}
+QUERY;
+
+        $response = $this->graphQlQuery($query);
+        $this->assertNotEmpty($response['categoryList'], 'Category list should not be empty');
+        $this->assertNull(
+            $response['categoryList'][0]['canonical_url']
+        );
+        $this->assertEquals('category-1-1', $response['categoryList'][0]['url_key']);
+    }
+}

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductCanonicalUrlTest.php

@@ -7,24 +7,17 @@
 
 namespace Magento\GraphQl\Catalog;
 
-use Magento\Catalog\Api\ProductRepositoryInterface;
-use Magento\TestFramework\ObjectManager;
 use Magento\TestFramework\TestCase\GraphQlAbstract;
-use Magento\UrlRewrite\Model\UrlFinderInterface;
-use Magento\TestFramework\Helper\Bootstrap;
-use Magento\UrlRewrite\Service\V1\Data\UrlRewrite as UrlRewriteDTO;
 
 /**
- * Test of getting URL rewrites data from products
+ * Test for getting canonical_url for products
  */
 class ProductCanonicalUrlTest extends GraphQlAbstract
 {
-    /** @var ObjectManager $objectManager */
-    private $objectManager;
-
     /**
      * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
      * @magentoConfigFixture default_store catalog/seo/product_canonical_tag 1
+     *
      */
     public function testProductWithCanonicalLinksMetaTagSettingsEnabled()
     {
@@ -43,12 +36,13 @@ public function testProductWithCanonicalLinksMetaTagSettingsEnabled()
 QUERY;
 
         $response = $this->graphQlQuery($query);
+        $this->assertNotEmpty($response['products']['items']);
 
         $this->assertEquals(
-            $response['products']['items'][0]['canonical_url'],
-            'simple-product.html'
+            'simple-product.html',
+            $response['products']['items'][0]['canonical_url']
         );
-        $this->assertEquals($response['products']['items'][0]['sku'], 'simple');
+        $this->assertEquals('simple', $response['products']['items'][0]['sku']);
     }
 
     /**
@@ -75,6 +69,6 @@ public function testProductWithCanonicalLinksMetaTagSettingsDisabled()
         $this->assertNull(
             $response['products']['items'][0]['canonical_url']
         );
-        $this->assertEquals($response['products']['items'][0]['sku'], 'simple');
+        $this->assertEquals('simple', $response['products']['items'][0]['sku']);
     }
 }