Skip to content

Commit 250af5b

Browse files
committed
AC-9138::Fedex Ship API upgrade from SOAP to REST - Fix Integration Test
1 parent e23dca5 commit 250af5b

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

app/code/Magento/Fedex/Model/Carrier.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -930,8 +930,8 @@ public function getTracking($trackings) : \Magento\Shipping\Model\Tracking\Resul
930930
*/
931931
protected function _getUrl($endpoint = null) : string
932932
{
933-
$url = $this->getConfigFlag('rest_sandbox_mode') ? $this->getConfigData('rest_sandbox_webservices_url')
934-
: $this->getConfigData('rest_production_webservices_url');
933+
$url = $this->getConfigFlag('sandbox_mode') ? $this->getConfigData('sandbox_webservices_url')
934+
: $this->getConfigData('production_webservices_url');
935935

936936
return $endpoint ? $url . $endpoint : $url;
937937
}

app/code/Magento/Fedex/etc/adminhtml/system.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,22 +45,22 @@
4545
<label>Secret Key</label>
4646
<backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model>
4747
</field>
48-
<field id="rest_sandbox_mode" translate="label" type="select" sortOrder="70" showInDefault="1" showInWebsite="1" canRestore="1">
48+
<field id="sandbox_mode" translate="label" type="select" sortOrder="70" showInDefault="1" showInWebsite="1" canRestore="1">
4949
<label>Sandbox Mode</label>
5050
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
5151
</field>
52-
<field id="rest_production_webservices_url" translate="label" type="text" sortOrder="80" showInDefault="1" showInWebsite="1" canRestore="1">
52+
<field id="production_webservices_url" translate="label" type="text" sortOrder="80" showInDefault="1" showInWebsite="1" canRestore="1">
5353
<label>Web-Services URL (Production)</label>
5454
<backend_model>Magento\Fedex\Model\Config\Backend\FedexUrl</backend_model>
5555
<depends>
56-
<field id="rest_sandbox_mode">0</field>
56+
<field id="sandbox_mode">0</field>
5757
</depends>
5858
</field>
59-
<field id="rest_sandbox_webservices_url" translate="label" type="text" sortOrder="90" showInDefault="1" showInWebsite="1" canRestore="1">
59+
<field id="sandbox_webservices_url" translate="label" type="text" sortOrder="90" showInDefault="1" showInWebsite="1" canRestore="1">
6060
<label>Web-Services URL (Sandbox)</label>
6161
<backend_model>Magento\Fedex\Model\Config\Backend\FedexUrl</backend_model>
6262
<depends>
63-
<field id="rest_sandbox_mode">1</field>
63+
<field id="sandbox_mode">1</field>
6464
</depends>
6565
</field>
6666
<field id="pickup_type" translate="label" type="select" sortOrder="100" showInDefault="1" showInWebsite="1" canRestore="1">

app/code/Magento/Fedex/etc/config.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
<account backend_model="Magento\Config\Model\Config\Backend\Encrypted" />
2727
<api_key backend_model="Magento\Config\Model\Config\Backend\Encrypted" />
2828
<secret_key backend_model="Magento\Config\Model\Config\Backend\Encrypted" />
29-
<rest_sandbox_mode>0</rest_sandbox_mode>
30-
<rest_production_webservices_url><![CDATA[https://apis.fedex.com/]]></rest_production_webservices_url>
31-
<rest_sandbox_webservices_url><![CDATA[https://apis-sandbox.fedex.com/]]></rest_sandbox_webservices_url>
29+
<sandbox_mode>0</sandbox_mode>
30+
<production_webservices_url><![CDATA[https://apis.fedex.com/]]></production_webservices_url>
31+
<sandbox_webservices_url><![CDATA[https://apis-sandbox.fedex.com/]]></sandbox_webservices_url>
3232
<pickup_type>DROPOFF_AT_FEDEX_LOCATION</pickup_type>
3333
<shipment_requesttype>0</shipment_requesttype>
3434
<active>0</active>

app/code/Magento/Fedex/etc/di.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
<arguments>
1111
<argument name="sensitive" xsi:type="array">
1212
<item name="carriers/fedex/account" xsi:type="string">1</item>
13-
<item name="carriers/fedex/key" xsi:type="string">1</item>
14-
<item name="carriers/fedex/meter_number" xsi:type="string">1</item>
15-
<item name="carriers/fedex/password" xsi:type="string">1</item>
13+
<item name="carriers/fedex/api_key" xsi:type="string">1</item>
14+
<item name="carriers/fedex/secret_key" xsi:type="string">1</item>
1615
<item name="carriers/fedex/production_webservices_url" xsi:type="string">1</item>
1716
<item name="carriers/fedex/sandbox_webservices_url" xsi:type="string">1</item>
1817
<item name="carriers/fedex/smartpost_hubid" xsi:type="string">1</item>

0 commit comments

Comments
 (0)