MAGETWO-67745: The "Catalog Search indexer process unknown error" appears after reindex

- Internal code review fixes.

Author: arnie1947

app/code/Magento/Catalog/Test/Unit/Model/ProductRepositoryTest.php

@@ -488,13 +488,13 @@ public function testGetByIdWhenCacheReduced()
         $expectedResult = [];
         $productsCount = $this->cacheLimit * 2;
 
-        $productMocks =  $this->getProductMocksForReducedCache();
+        $productMocks =  $this->getProductMocksForReducedCache($productsCount);
         $productFactoryInvMock = $this->productFactoryMock->expects($this->exactly($productsCount))
             ->method('create');
         call_user_func_array([$productFactoryInvMock, 'willReturnOnConsecutiveCalls'], $productMocks);
         $this->serializerMock->expects($this->atLeastOnce())->method('serialize');
 
-        for ($i = 1; $i <= $productsCount; $i ++) {
+        for ($i = 1; $i <= $productsCount; $i++) {
             $product = $this->model->getById($i, false, 0);
             $result[] = $product->getId();
             $expectedResult[] = $i;
@@ -506,13 +506,14 @@ public function testGetByIdWhenCacheReduced()
     /**
      * Get product mocks for testGetByIdWhenCacheReduced() method.
      *
+     * @param int $productsCount
      * @return array
      */
-    private function getProductMocksForReducedCache()
+    private function getProductMocksForReducedCache($productsCount)
     {
         $productMocks = [];
 
-        for ($i = 1; $i <= $this->cacheLimit * 2; $i ++) {
+        for ($i = 1; $i <= $productsCount; $i++) {
             $productMock = $this->getMockBuilder(\Magento\Catalog\Model\Product::class)
                 ->disableOriginalConstructor()
                 ->setMethods([