MAGETWO-39117: Updating qty that exceeds the qty in stock for registered customer by API should return error

refactored as factory

Author: Serhiy Shkolyarenko

app/code/Magento/Quote/Model/QuoteRepository/SaveHandler.php

@@ -5,9 +5,10 @@
  */
 namespace Magento\Quote\Model\QuoteRepository;
 
+use Magento\Framework\App\ObjectManager;
 use Magento\Quote\Api\Data\CartInterface;
 use Magento\Framework\Exception\InputException;
-use Magento\Framework\Exception\CouldNotSaveMultiMessageException;
+use Magento\Framework\Exception\CouldNotSaveException;
 
 class SaveHandler
 {
@@ -31,6 +32,11 @@ class SaveHandler
      */
     private $shippingAssignmentPersister;
 
+    /**
+     * @var \Magento\Framework\Message\PhraseFactory
+     */
+    private $phraseFactory;
+
     /**
      * @param \Magento\Quote\Model\ResourceModel\Quote $quoteResource
      * @param \Magento\Quote\Model\Quote\Item\CartItemPersister $cartItemPersister
@@ -73,7 +79,10 @@ public function save(CartInterface $quote)
         }
         $errors = $quote->getErrors();
         if (!empty($errors)) {
-            throw new CouldNotSaveMultiMessageException('Following errors occurred on save: %1', $errors);
+            $phraseFactory = $this->getPhraseFactory();
+            throw new CouldNotSaveException(
+                $phraseFactory->create('Following errors occurred on save: %1', $errors)
+            );
         }
 
         // Billing Address processing
@@ -88,6 +97,18 @@ public function save(CartInterface $quote)
         return $quote;
     }
 
+    /**
+     * @deprecated
+     * @return \Magento\Framework\Message\PhraseFactory
+     */
+    private function getPhraseFactory()
+    {
+        if (!is_object($this->phraseFactory)) {
+            $this->phraseFactory = ObjectManager::getInstance()->get(\Magento\Framework\Message\PhraseFactory::class);
+        }
+        return $this->phraseFactory;
+    }
+
     /**
      * @param \Magento\Quote\Model\Quote $quote
      * @return void

lib/internal/Magento/Framework/Message/PhraseFactory.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Framework\Message;
+
+use Magento\Framework\Phrase;
+use Magento\Framework\Message\MessageInterface;
+
+/**
+ * Factory to combine several messages into one
+ */
+class PhraseFactory
+{
+    /**
+     * Combine submessages delimited by separator and render them with main message
+     *
+     * @param string $mainMessage
+     * @param MessageInterface[] $subMessages
+     * @param string $separator
+     * @return Phrase
+     */
+    public function create($mainMessage, $subMessages, $separator = '; ')
+    {
+        $renderedErrors = '';
+        $eol = '';
+        /** @var MessageInterface $subMessage */
+        foreach ($subMessages as $subMessage) {
+            if ($subMessage instanceof MessageInterface) {
+                $phrase = new Phrase($subMessage->getText());
+            } else {
+                $phrase = new Phrase('Cannot render error message!');
+            }
+            $renderedErrors .= $eol . $phrase->render();
+            $eol = $separator;
+        }
+
+        //$mainMessage should contain %1 to be substituted by concatenated errors
+        return new Phrase($mainMessage, [$renderedErrors]);
+    }
+}