functionality fixes, edit jasmine unit test

Author: rostilos

app/code/Magento/Checkout/view/frontend/web/js/model/cart/estimate-service.js

@@ -41,7 +41,6 @@ define([
                 totalsProcessors[type] ?
                     totalsProcessors[type].estimateTotals(quote.shippingAddress()) :
                     totalsProcessors['default'].estimateTotals(quote.shippingAddress());
-                shippingService.isLoading(false);
             } else {
                 // check if user data not changed -> load rates from cache
                 if (!cartCache.isChanged('address', quote.shippingAddress()) &&
@@ -73,6 +72,8 @@ define([
                     cartCache.set('totals', quote.getTotals());
                 }
             }
+            // unset loader on shipping rates list
+            shippingService.isLoading(false);
         },
 
         /**

app/code/Magento/Checkout/view/frontend/web/js/model/shipping-rates-validator.js

@@ -148,6 +148,7 @@ define([
                     }, delay);
 
                     if (!formPopUpState.isVisible()) {
+                        // Prevent shipping methods showing none available whilst we resolve
                         shippingService.isLoading(true);
                         clearTimeout(self.validateAddressTimeout);
                         self.validateAddressTimeout = setTimeout(function () {

dev/tests/js/jasmine/tests/app/code/Magento/Checkout/frontend/js/model/cart/estimate-service.test.js

@@ -41,6 +41,7 @@ define([
             },
             'Magento_Checkout/js/model/shipping-service': {
                 setShippingRates: function () {},
+                isLoading: ko.observable(),
                 getShippingRates: function () {
                     return ko.observable(rates);
                 }