Skip to content

Commit 2353daf

Browse files
committed
Merge pull request #16 from magento-extensibility/MAGETWO-31776-add-parent-element-theme
[Extensibility] Magetwo 31776 add parent element theme
2 parents a398195 + e0bb974 commit 2353daf

File tree

68 files changed

+78
-398
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+78
-398
lines changed

app/code/Magento/Core/Model/Theme/Collection.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -268,15 +268,7 @@ protected function _getConfigModel($configPath)
268268
$relativeConfigPath = $this->_directory->getRelativePath($configPath);
269269
$configContent = $this->_directory->isExist($relativeConfigPath) ?
270270
$this->_directory->readFile($relativeConfigPath) : null;
271-
$relativeComposerPath = dirname($relativeConfigPath) . '/composer.json';
272-
$composerContent = $this->_directory->isExist($relativeComposerPath) ?
273-
$this->_directory->readFile($relativeComposerPath) : null;
274-
return $this->themeConfigFactory->create(
275-
[
276-
'configContent' => $configContent,
277-
'composerContent' => $composerContent,
278-
]
279-
);
271+
return $this->themeConfigFactory->create(['configContent' => $configContent]);
280272
}
281273

282274
/**

app/design/adminhtml/Magento/backend/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento 2 backend</title>
8+
<version>0.1.0</version>
89
</theme>

app/design/frontend/Magento/blank/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento Blank</title>
8+
<version>0.1.0</version>
89
<media>
910
<preview_image>media/preview.jpg</preview_image>
1011
</media>

app/design/frontend/Magento/luma/theme.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento Luma</title>
8+
<version>0.1.0</version>
9+
<parent>Magento/blank</parent>
810
<media>
911
<preview_image>media/preview.jpg</preview_image>
1012
</media>

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/a_d/composer.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/a_d/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Theme D</title>
9+
<version>0.1.0</version>
910
</theme>

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/b_e/composer.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/b_e/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Theme E</title>
9+
<version>0.1.0</version>
910
</theme>

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/magento_default/composer.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev/tests/integration/testsuite/Magento/Core/Model/Theme/Source/_files/design/frontend/magento_default/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Default</title>
9+
<version>0.1.0</version>
910
</theme>

0 commit comments

Comments
 (0)