MAGETWO-71013: Export missing configurable variations when exporting more than one item

- Clean up formatting, unused variables, and documentation
- Add optional dependencies to support running new Import/Replace w/ pagination

Author: tjwiebell

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/AbstractProductExportImportTestCase.php

@@ -6,7 +6,6 @@
 namespace Magento\CatalogImportExport\Model;
 
 use Magento\Framework\App\Bootstrap;
-use Magento\Framework\App\Config;
 use Magento\Framework\App\Filesystem\DirectoryList;
 
 /**
@@ -16,11 +15,6 @@
  */
 abstract class AbstractProductExportImportTestCase extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * @var \Magento\CatalogImportExport\Model\Export\Product
-     */
-    protected $model;
-
     /**
      * @var \Magento\Framework\ObjectManagerInterface
      */
@@ -61,8 +55,6 @@ abstract class AbstractProductExportImportTestCase extends \PHPUnit\Framework\Te
 
     protected function setUp()
     {
-        parent::setUp();
-
         $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
         $this->fileSystem = $this->objectManager->get(\Magento\Framework\Filesystem::class);
         $this->productResource = $this->objectManager->create(
@@ -262,9 +254,33 @@ public function testImportReplace($fixtures, $skus, $skippedAttributes = [])
     }
 
     /**
+     * @magentoAppArea adminhtml
+     * @magentoDbIsolation enabled
+     * @magentoAppIsolation enabled
+     *
+     * @param array $fixtures
+     * @param string[] $skus
+     * @param string[] $skippedAttributes
+     * @dataProvider importReplaceDataProvider
+     */
+    public function testImportReplaceWithPagination($fixtures, $skus, $skippedAttributes = [])
+    {
+        $this->fixtures = $fixtures;
+        $this->executeFixtures($fixtures, $skus);
+        $this->modifyData($skus);
+        $skippedAttributes = array_merge(self::$skippedAttributes, $skippedAttributes);
+        $this->executeImportReplaceTest($skus, $skippedAttributes, true);
+    }
+
+    /**
+     * @param string[] $skus
+     * @param string[] $skippedAttributes
+     * @param bool $usePagination
+     *
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
-    protected function executeImportReplaceTest($skus, $skippedAttributes)
+    protected function executeImportReplaceTest($skus, $skippedAttributes, $usePagination = false)
     {
         $replacedAttributes = [
             'row_id',
@@ -285,7 +301,18 @@ protected function executeImportReplaceTest($skus, $skippedAttributes)
             $index++;
         }
 
-        $csvfile = $this->exportProducts();
+        $exportProduct = $this->objectManager->create(\Magento\CatalogImportExport\Model\Export\Product::class);
+        if ($usePagination) {
+            /** @var \ReflectionProperty $itemsPerPageProperty */
+            $itemsPerPageProperty = $this->objectManager->create(\ReflectionProperty::class, [
+                'class' => \Magento\CatalogImportExport\Model\Export\Product::class,
+                'name' => '_itemsPerPage'
+            ]);
+            $itemsPerPageProperty->setAccessible(true);
+            $itemsPerPageProperty->setValue($exportProduct, 1);
+        }
+
+        $csvfile = $this->exportProducts($exportProduct);
         $this->importProducts($csvfile, \Magento\ImportExport\Model\Import::BEHAVIOR_REPLACE);
 
         while ($index > 0) {
@@ -326,13 +353,16 @@ protected function executeImportReplaceTest($skus, $skippedAttributes)
     /**
      * Export products in the system
      *
+     * @param \Magento\CatalogImportExport\Model\Export\Product|null $exportProduct
      * @return string Return exported file name
      */
-    private function exportProducts()
+    private function exportProducts(\Magento\CatalogImportExport\Model\Export\Product $exportProduct = null)
     {
         $csvfile = uniqid('importexport_') . '.csv';
 
-        $exportProduct = $this->objectManager->create(\Magento\CatalogImportExport\Model\Export\Product::class);
+        $exportProduct = $exportProduct ?: $this->objectManager->create(
+            \Magento\CatalogImportExport\Model\Export\Product::class
+        );
         $exportProduct->setWriter(
             \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
                 \Magento\ImportExport\Model\Export\Adapter\Csv::class,

dev/tests/integration/testsuite/Magento/CatalogImportExport/_files/product_export_data.php

@@ -79,8 +79,6 @@
     \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED
 )->setWebsiteIds(
     [1]
-)->setCateroryIds(
-    []
 )->setStockData(
     ['qty' => 100, 'is_in_stock' => 1]
 )->setCanSaveCustomOptions(

dev/tests/integration/testsuite/Magento/ConfigurableImportExport/Model/ConfigurableTest.php

@@ -39,10 +39,10 @@ public function exportImportDataProvider()
      */
     protected function assertEqualsSpecificAttributes($expectedProduct, $actualProduct)
     {
-        /** @var \Magento\ConfigurableProduct\Model\Product\Type\Configurable $prooductType */
-        $prooductType = $expectedProduct->getTypeInstance();
-        $expectedAssociatedProducts = $prooductType->getUsedProductCollection($expectedProduct);
-        $actualAssociatedProducts = iterator_to_array($prooductType->getUsedProductCollection($actualProduct));
+        /** @var \Magento\ConfigurableProduct\Model\Product\Type\Configurable $productType */
+        $productType = $expectedProduct->getTypeInstance();
+        $expectedAssociatedProducts = $productType->getUsedProductCollection($expectedProduct);
+        $actualAssociatedProducts = iterator_to_array($productType->getUsedProductCollection($actualProduct));
 
         $expectedAssociatedProductSkus = [];
         $actualAssociatedProductSkus = [];
@@ -103,19 +103,4 @@ public function importReplaceDataProvider()
         }
         return $data;
     }
-
-    /**
-     * @magentoAppArea adminhtml
-     * @magentoDbIsolation enabled
-     * @magentoAppIsolation enabled
-     *
-     * @param array $fixtures
-     * @param string[] $skus
-     * @param string[] $skippedAttributes
-     * @dataProvider importReplaceDataProvider
-     */
-    public function testImportReplace($fixtures, $skus, $skippedAttributes = [])
-    {
-        parent::testImportReplace($fixtures, $skus, $skippedAttributes);
-    }
 }