Skip to content

Commit 23008f6

Browse files
committed
Merge branch 'MAGETWO-88890' into MPI-PR-2.2.5
2 parents e3a59d7 + e5c6c87 commit 23008f6

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

dev/tests/static/testsuite/Magento/Test/Integrity/ComposerTest.php

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,14 @@ private function assertMagentoConventions($dir, $packageType, \StdClass $json)
192192
}
193193

194194
/**
195-
* Returns true if package vendor is Magento.
195+
* Checks if package vendor is Magento.
196196
*
197197
* @param string $packageName
198198
* @return bool
199199
*/
200200
private function isVendorMagento($packageName)
201201
{
202-
return strpos($packageName, 'magento') === 0;
202+
return strpos($packageName, 'magento/') === 0;
203203
}
204204

205205
/**
@@ -289,12 +289,24 @@ private function assertDependsOnFramework(\StdClass $json)
289289
private function assertPhpVersionInSync($name, $phpVersion)
290290
{
291291
if (isset(self::$rootJson['require']['php'])) {
292-
$this->assertEquals(
293-
self::$rootJson['require']['php'],
294-
$phpVersion,
295-
"PHP version {$phpVersion} in component {$name} is inconsistent with version "
296-
. self::$rootJson['require']['php'] . ' in root composer.json'
297-
);
292+
if ($this->isVendorMagento($name)) {
293+
$this->assertEquals(
294+
self::$rootJson['require']['php'],
295+
$phpVersion,
296+
"PHP version {$phpVersion} in component {$name} is inconsistent with version "
297+
. self::$rootJson['require']['php'] . ' in root composer.json'
298+
);
299+
} else {
300+
$composerVersionsPattern = '{\s*\|\|?\s*}';
301+
$rootPhpVersions = preg_split($composerVersionsPattern, self::$rootJson['require']['php']);
302+
$modulePhpVersions = preg_split($composerVersionsPattern, $phpVersion);
303+
304+
$this->assertEmpty(
305+
array_diff($rootPhpVersions, $modulePhpVersions),
306+
"PHP version {$phpVersion} in component {$name} is inconsistent with version "
307+
. self::$rootJson['require']['php'] . ' in root composer.json'
308+
);
309+
}
298310
}
299311
}
300312

0 commit comments

Comments
 (0)