ACP2E-1875: [Magento Cloud] Products incorrectly showed Out of Stock then all products show in stock

- added unit tests

Author: aplapana

app/code/Magento/CatalogSearch/Test/Unit/Model/Indexer/FulltextTest.php

@@ -117,6 +117,9 @@ public function testExecute()
         $this->fulltextResource->expects($this->exactly(2))
             ->method('getRelationsByChild')
             ->willReturn($ids);
+        $this->saveHandler->expects($this->exactly(count($stores)))->method('enableStackedActions');
+        $this->saveHandler->expects($this->exactly(count($stores)))->method('triggerStackedActions');
+        $this->saveHandler->expects($this->exactly(count($stores)))->method('disableStackedActions');
         $this->saveHandler->expects($this->exactly(count($stores)))->method('deleteIndex');
         $this->saveHandler->expects($this->exactly(2))->method('saveIndex');
         $this->saveHandler->expects($this->exactly(2))->method('isAvailable')->willReturn(true);
@@ -134,6 +137,40 @@ function ($store) use ($ids) {
         $this->model->execute($ids);
     }
 
+    public function testExecuteWithStackedQueriesException()
+    {
+        $ids = [1, 2, 3];
+        $stores = [0 => 'Store 1'];
+        $this->setupDataProvider($stores);
+
+        $indexData = new \ArrayObject([]);
+        $this->fulltextResource->expects($this->exactly(1))
+            ->method('getRelationsByChild')
+            ->willReturn($ids);
+        $this->saveHandler->expects($this->exactly(count($stores)))->method('enableStackedActions');
+        $this->saveHandler->expects($this->exactly(count($stores) + 1))->method('deleteIndex');
+        $this->saveHandler->expects($this->exactly(count($stores) + 1))->method('saveIndex');
+        $this->saveHandler->expects($this->exactly(count($stores)))
+            ->method('triggerStackedActions')
+            ->willThrowException(new \Exception('error'));
+        $this->saveHandler->expects($this->exactly(count($stores)))->method('disableStackedActions');
+
+        $this->saveHandler->expects($this->exactly(2))->method('saveIndex');
+        $this->saveHandler->expects($this->exactly(1))->method('isAvailable')->willReturn(true);
+        $consecutiveStoreRebuildArguments = array_map(
+            function ($store) use ($ids) {
+                return [$store, $ids];
+            },
+            $stores
+        );
+        $this->fullAction->expects($this->exactly(2))
+            ->method('rebuildStoreIndex')
+            ->withConsecutive(...$consecutiveStoreRebuildArguments)
+            ->willReturn(new \ArrayObject([$indexData, $indexData]));
+
+        $this->model->execute($ids);
+    }
+
     /**
      * @param $stores
      */

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/ElasticsearchTest.php

@@ -312,6 +312,39 @@ public function testAddDocs(): void
         );
     }
 
+    /**
+     * @return void
+     * @throws Exception
+     */
+    public function testAddDocsStackedQueries(): void
+    {
+        $this->client->expects($this->once())
+            ->method('bulkQuery');
+        $this->model->enableStackQueriesMode();
+        $this->assertSame(
+            $this->model,
+            $this->model->addDocs(
+                ['1' => ['name' => 'Product Name'],
+                ],
+                1,
+                'product'
+            )
+        );
+        $this->model->triggerStackedQueries();
+    }
+
+    /**
+     * @return void
+     * @throws Exception
+     */
+    public function testTriggerStackedQueriesWhenEmpty(): void
+    {
+        $this->client->expects($this->never())
+            ->method('bulkQuery');
+        $this->model->enableStackQueriesMode();
+        $this->model->triggerStackedQueries();
+    }
+
     /**
      * Test addDocs() method
      *
@@ -378,6 +411,21 @@ public function testDeleteDocs(): void
         );
     }
 
+    /**
+     * @return void
+     * @throws Exception
+     */
+    public function testDeleteDocsStackedQueries(): void
+    {
+        $this->client->expects($this->once())
+            ->method('bulkQuery');
+        $this->assertSame(
+            $this->model,
+            $this->model->deleteDocs(['1' => 1], 1, 'product'));
+        $this->model->enableStackQueriesMode();
+        $this->model->triggerStackedQueries();
+    }
+
     /**
      * Test deleteDocs() method
      *

app/code/Magento/Elasticsearch/Test/Unit/Model/Indexer/IndexerHandlerTest.php

@@ -180,6 +180,27 @@ protected function setUp(): void
         );
     }
 
+    public function testDisableStackedActions(): void
+    {
+        $this->adapter->expects($this->once())->method('disableStackQueriesMode');
+        $this->model->disableStackedActions();
+    }
+
+    public function testEnableStackedActions(): void
+    {
+        $this->adapter->expects($this->once())->method('enableStackQueriesMode');
+        $this->model->enableStackedActions();
+    }
+
+    /**
+     * @throws \Exception
+     */
+    public function testTriggerStackedActions(): void
+    {
+        $this->adapter->expects($this->once())->method('triggerStackedQueries');
+        $this->model->triggerStackedActions();
+    }
+
     public function testIsAvailable()
     {
         $this->adapter->expects($this->any())