MAGETWO-89247: Run catalog search indexer by dimension

Author: mslabko

app/code/Magento/CatalogSearch/Test/Unit/Model/Indexer/FulltextTest.php

@@ -5,7 +5,7 @@
  */
 namespace Magento\CatalogSearch\Test\Unit\Model\Indexer;
 
-use \Magento\Framework\MultiDimensionalIndexer\Dimension;
+use \Magento\Framework\Indexer\Dimension;
 use Magento\Framework\Indexer\Dimension\DimensionProviderInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
 

app/code/Magento/Store/Model/StoreDimensionProvider.php

@@ -7,7 +7,7 @@
 
 namespace Magento\Store\Model;
 
-use Magento\Framework\MultiDimensionalIndexer\DimensionFactory;
+use Magento\Framework\Indexer\DimensionFactory;
 use Magento\Framework\Indexer\Dimension\DimensionProviderInterface;
 
 /**

dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php

@@ -334,8 +334,6 @@ public function testStrictTypes()
     {
         $changedFiles = self::getAddedFilesList('');
 
-        $componentRegistrar = new ComponentRegistrar();
-        $directoriesToCheck = $componentRegistrar->getPaths(ComponentRegistrar::MODULE);
         try {
             $blackList = Files::init()->readLists(
                 self::getBaseFilesFolder() . '/_files/blacklist/strict_type.txt'
@@ -346,7 +344,7 @@ public function testStrictTypes()
         }
 
         $toBeTestedFiles = array_diff(
-            self::filterFiles($changedFiles, ['php'], $directoriesToCheck),
+            self::filterFiles($changedFiles, ['php'], []),
             $blackList
         );
 

lib/internal/Magento/Framework/Indexer/Dimension.php

@@ -0,0 +1,46 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Framework\Indexer;
+
+/**
+ * Index Dimension object
+ *
+ * @api
+ */
+class Dimension
+{
+    /**
+     * @param string $name
+     * @param string $value
+     */
+    public function __construct(string $name, string $value)
+    {
+        $this->name = $name;
+        $this->value = $value;
+    }
+
+    /**
+     * Get dimension name
+     *
+     * @return string
+     */
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    /**
+     * Get dimension value
+     *
+     * @return string
+     */
+    public function getValue(): string
+    {
+        return $this->value;
+    }
+}

lib/internal/Magento/Framework/Indexer/Dimension/DimensionProviderInterface.php

@@ -14,8 +14,8 @@
 interface DimensionProviderInterface extends \IteratorAggregate
 {
     /**
-     * Get Dimension Iterator. Returns yielded value of \Magento\Framework\MultiDimensionalIndexer\Dimension
-     * @return \Traversable|\Magento\Framework\MultiDimensionalIndexer\Dimension[]
+     * Get Dimension Iterator. Returns yielded value of \Magento\Framework\Indexer\Dimension
+     * @return \Traversable|\Magento\Framework\Indexer\Dimension[]
      */
     public function getIterator(): \Traversable;
 }

lib/internal/Magento/Framework/Indexer/Dimension/DimensionalIndexerInterface.php

@@ -17,7 +17,7 @@ interface DimensionalIndexerInterface
      * Execute indexer by specified dimension.
      * Accept array of dimensions DTO that represent indexer dimension
      *
-     * @param \Magento\Framework\MultiDimensionalIndexer\Dimension[] $dimension
+     * @param \Magento\Framework\Indexer\Dimension[] $dimension
      * @param \Traversable|null $entityIds
      * @return void
      */

lib/internal/Magento/Framework/Indexer/DimensionFactory.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Framework\Indexer;
+
+use Magento\Framework\ObjectManagerInterface;
+
+/**
+ * Dimension Factory
+ *
+ * @api
+ */
+class DimensionFactory
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    /**
+     * @param ObjectManagerInterface $objectManager
+     */
+    public function __construct(ObjectManagerInterface $objectManager)
+    {
+        $this->objectManager = $objectManager;
+    }
+
+    /**
+     * @param string $name
+     * @param string $value
+     * @return Dimension
+     */
+    public function create(string $name, $value): Dimension
+    {
+        return $this->objectManager->create(Dimension::class, [
+            'name' => $name,
+            'value' => (string) $value,
+        ]);
+    }
+}