MAGETWO-35411: [GITHUB] Incorrect use of implode() #1116

vpelipenko · vpelipenko · commit 21f1ebd14662 · 2015-03-24T15:19:23.000+02:00
diff --git a/app/code/Magento/Tax/Setup/InstallData.php b/app/code/Magento/Tax/Setup/InstallData.php
@@ -69,7 +69,7 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface
                 'visible_in_advanced_search' => true,
                 'used_in_product_listing' => true,
                 'unique' => false,
-                'apply_to' => implode($taxSetup->getTaxableItems(), ',')
+                'apply_to' => implode(',', $taxSetup->getTaxableItems())
             ]
         );
 

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface`
`69`	`69`	`'visible_in_advanced_search' => true,`
`70`	`70`	`'used_in_product_listing' => true,`
`71`	`71`	`'unique' => false,`
`72`		`- 'apply_to' => implode($taxSetup->getTaxableItems(), ',')`
	`72`	`+ 'apply_to' => implode(',', $taxSetup->getTaxableItems())`
`73`	`73`	`]`
`74`	`74`	`);`
`75`	`75`