MAGETWO-54680: Order status change after Creditmemo creation through API. L3 fixes

Author: valdislav

app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Item/Validation/CreateQuantityValidatorTest.php

@@ -3,42 +3,43 @@
  * Copyright © 2016 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Sales\Test\Unit\Model\Order\Creditmemo;
+namespace Magento\Sales\Test\Unit\Model\Order\Creditmemo\Item\Validation;
 
 use Magento\Sales\Api\OrderItemRepositoryInterface;
 use Magento\Sales\Model\Order\Creditmemo\Item\Validation\CreationQuantityValidator;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Model\Order\Item;
 
-
-
+/**
+ * Class CreateQuantityValidatorTest
+ */
 class CreateQuantityValidatorTest extends \PHPUnit_Framework_TestCase
 {
     /**
      * @var OrderItemRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $orderItemRepositoryMock;
+    private $orderItemRepositoryMock;
 
     /**
      * @var Item|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $orderItemMock;
+    private $orderItemMock;
 
     /**
      * @var CreationQuantityValidator|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $createQuantityValidator;
+    private $createQuantityValidator;
 
     /**
      * @var OrderInterface|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $contexMock;
+    private $contexMock;
 
     /**
      * @var \stdClass|\PHPUnit_Framework_MockObject_MockObject
      */
-    protected $entity;
+    private $entity;
 
     protected function setUp()
     {
@@ -88,7 +89,7 @@ public function testValidateCreditMemoProductItems($orderItemId, $expectedResult
                 ->willReturn(11);
         }
 
-        $this->createQuantityValidator = New CreationQuantityValidator(
+        $this->createQuantityValidator = new CreationQuantityValidator(
             $this->orderItemRepositoryMock,
             $this->contexMock
         );

app/code/Magento/Sales/Test/Unit/Model/RefundInvoiceTest.php

@@ -151,31 +151,25 @@ protected function setUp()
         $this->resourceConnectionMock = $this->getMockBuilder(ResourceConnection::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->orderRepositoryMock = $this->getMockBuilder(OrderRepositoryInterface::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->invoiceRepositoryMock = $this->getMockBuilder(InvoiceRepositoryInterface::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->creditmemoDocumentFactoryMock = $this->getMockBuilder(CreditmemoDocumentFactory::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->creditmemoValidatorMock = $this->getMockBuilder(CreditmemoValidatorInterface::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->orderValidatorMock = $this->getMockBuilder(OrderValidatorInterface::class)
             ->disableOriginalConstructor()
             ->getMock();
-
         $this->invoiceValidatorMock = $this->getMockBuilder(InvoiceValidatorInterface::class)
             ->disableOriginalConstructor()
             ->getMock();
-
+        
         $this->paymentAdapterMock = $this->getMockBuilder(PaymentAdapterInterface::class)
             ->disableOriginalConstructor()
             ->getMock();