MAGETWO-63159: Fix Sales Rule Data Model convertor to support extension attributes

Author: slavvka

app/code/Magento/SalesRule/Model/Converter/ToDataModel.php

@@ -84,7 +84,7 @@ public function __construct(
      * @param Rule $ruleModel
      * @return RuleDataModel
      */
-    public function toDataModel(\Magento\SalesRule\Model\Rule $ruleModel)
+    public function toDataModel(Rule $ruleModel)
     {
         $modelData = $ruleModel->getData();
         $modelData = $this->convertExtensionAttributesToObject($modelData);
@@ -99,10 +99,10 @@ public function toDataModel(\Magento\SalesRule\Model\Rule $ruleModel)
 
     /**
      * @param RuleDataModel $dataModel
-     * @param \Magento\SalesRule\Model\Rule $ruleModel
+     * @param Rule $ruleModel
      * @return $this
      */
-    protected function mapConditions(RuleDataModel $dataModel, \Magento\SalesRule\Model\Rule $ruleModel)
+    protected function mapConditions(RuleDataModel $dataModel, Rule $ruleModel)
     {
         $conditionSerialized = $ruleModel->getConditionsSerialized();
         if ($conditionSerialized) {
@@ -117,10 +117,10 @@ protected function mapConditions(RuleDataModel $dataModel, \Magento\SalesRule\Mo
 
     /**
      * @param RuleDataModel $dataModel
-     * @param \Magento\SalesRule\Model\Rule $ruleModel
+     * @param Rule $ruleModel
      * @return $this
      */
-    protected function mapActionConditions(RuleDataModel $dataModel, \Magento\SalesRule\Model\Rule $ruleModel)
+    protected function mapActionConditions(RuleDataModel $dataModel, Rule $ruleModel)
     {
         $actionConditionSerialized = $ruleModel->getActionsSerialized();
         if ($actionConditionSerialized) {
@@ -194,10 +194,11 @@ private function convertExtensionAttributesToObject(array $data)
     }
 
     /**
-     * @param \Magento\SalesRule\Model\Rule $ruleModel
+     * @param RuleDataModel $dataModel
+     * @param Rule $ruleModel
      * @return $this
      */
-    protected function mapFields(RuleDataModel $dataModel, \Magento\SalesRule\Model\Rule $ruleModel)
+    protected function mapFields(RuleDataModel $dataModel, Rule $ruleModel)
     {
         $this->mapConditions($dataModel, $ruleModel);
         $this->mapActionConditions($dataModel, $ruleModel);