MAGETWO-62253: Refactor code to remove unserialize

- fixed tests

Author: buskamuza

app/code/Magento/Backend/Test/Unit/Model/MenuTest.php

@@ -368,14 +368,9 @@ public function testUnserialize()
             ->method('unserialize')
             ->willReturn([['unserializedData']]);
         $menuItemFactoryMock = $this->getMock(Factory::class, [], [], '', false);
-        $menuItemMock = $this->getMock(Item::class, [], [], '', false);
         $menuItemFactoryMock->expects($this->once())
             ->method('create')
-            ->willReturn($menuItemMock);
-        $menuItemMock->expects($this->once())
-            ->method('populateFromArray')
-            ->with(['unserializedData'])
-            ->willReturn($this);
+            ->with(['unserializedData']);
         $menu = $this->objectManagerHelper->getObject(
             \Magento\Backend\Model\Menu::class,
             [

dev/tests/integration/testsuite/Magento/Backend/Model/MenuTest.php

@@ -78,7 +78,10 @@ public function testMenuItemManipulation()
         $menu->move('Magento_Catalog::catalog_products', 'Magento_Backend::system2');
     }
 
-    public function testSerializeUnserialize()
+    /**
+     * @magentoAppIsolation enabled
+     */
+    public function testSerialize()
     {
         /** @var Menu $menu */
         $menu = $this->objectManager->get(\Magento\Backend\Model\MenuFactory::class)->create();
@@ -111,9 +114,63 @@ public function testSerializeUnserialize()
             'Magento_Backend::system3'
         );
         $serializedString = $menu->serialize();
-        /** @var Menu $unserializedMenu */
-        $unserializedMenu = $this->objectManager->get(\Magento\Backend\Model\MenuFactory::class)->create();
-        $unserializedMenu->unserialize($serializedString);
-        $this->assertEquals($menu, $unserializedMenu);
+        $expected = '[{"parent_id":null,"module_name":"Magento_Backend","sort_index":null,"depends_on_config":null,'
+            . '"id":"Magento_Backend::system3","resource":"Magento_Backend::system3","path":"","action":null,'
+            . '"depends_on_module":null,"tooltip":"","title":"Extended System",'
+            . '"sub_menu":[{"parent_id":null,"module_name":"Magento_Backend","sort_index":null,'
+            . '"depends_on_config":null,"id":"Magento_Backend::system3_acl","resource":"Magento_Backend::system3_acl",'
+            . '"path":"","action":"admin\/backend\/acl\/index","depends_on_module":null,"tooltip":"","title":"Acl",'
+            . '"sub_menu":null}]}]';
+        $this->assertEquals($expected, $serializedString);
+    }
+
+    /**
+     * @magentoAppIsolation enabled
+     */
+    public function testUnserialize()
+    {
+        $serializedMenu = '[{"parent_id":null,"module_name":"Magento_Backend","sort_index":null,'
+            . '"depends_on_config":null,"id":"Magento_Backend::system3","resource":"Magento_Backend::system3",'
+            . '"path":"","action":null,"depends_on_module":null,"tooltip":"","title":"Extended System",'
+            . '"sub_menu":[{"parent_id":null,"module_name":"Magento_Backend","sort_index":null,'
+            . '"depends_on_config":null,"id":"Magento_Backend::system3_acl","resource":"Magento_Backend::system3_acl",'
+            . '"path":"","action":"admin\/backend\/acl\/index","depends_on_module":null,"tooltip":"","title":"Acl",'
+            . '"sub_menu":null}]}]';
+        /** @var Menu $menu */
+        $menu = $this->objectManager->get(\Magento\Backend\Model\MenuFactory::class)->create();
+        $menu->unserialize($serializedMenu);
+        $expected = [
+            [
+                'parent_id' => null,
+                'module_name' => 'Magento_Backend',
+                'sort_index' => null,
+                'depends_on_config' => null,
+                'id' => 'Magento_Backend::system3',
+                'resource' => 'Magento_Backend::system3',
+                'path' => '',
+                'action' => null,
+                'depends_on_module' => null,
+                'tooltip' => '',
+                'title' => 'Extended System',
+                'sub_menu' =>
+                    [
+                        [
+                            'parent_id' => null,
+                            'module_name' => 'Magento_Backend',
+                            'sort_index' => null,
+                            'depends_on_config' => null,
+                            'id' => 'Magento_Backend::system3_acl',
+                            'resource' => 'Magento_Backend::system3_acl',
+                            'path' => '',
+                            'action' => 'admin/backend/acl/index',
+                            'depends_on_module' => null,
+                            'tooltip' => '',
+                            'title' => 'Acl',
+                            'sub_menu' => null,
+                        ],
+                    ],
+            ],
+        ];
+        $this->assertEquals($expected, $menu->toArray());
     }
 }