ACP2E-3493: addressed CR comment

Author: alzota

app/code/Magento/Persistent/Model/CleanExpiredPersistentQuotes.php

@@ -27,13 +27,15 @@ class CleanExpiredPersistentQuotes
      * @param QuoteRepository $quoteRepository
      * @param Snapshot $snapshot
      * @param LoggerInterface $logger
+     * @param int $batchSize
      */
     public function __construct(
         private readonly StoreManagerInterface $storeManager,
         private readonly ExpiredPersistentQuotesCollection $expiredPersistentQuotesCollection,
         private readonly QuoteRepository $quoteRepository,
-        private Snapshot $snapshot,
-        private readonly LoggerInterface $logger
+        private readonly Snapshot $snapshot,
+        private readonly LoggerInterface $logger,
+        private readonly int $batchSize
     ) {
     }
 
@@ -60,12 +62,11 @@ public function execute(int $websiteId): void
      */
     private function processStoreQuotes(StoreInterface $store): void
     {
-        $batchSize = 500;
         $lastProcessedId = $count = 0;
 
         while (true) {
             $quotesToProcess = $this->expiredPersistentQuotesCollection
-                ->getExpiredPersistentQuotes($store, $lastProcessedId, $batchSize);
+                ->getExpiredPersistentQuotes($store, $lastProcessedId, $this->batchSize);
 
             if (!$quotesToProcess->count()) {
                 break;
@@ -83,7 +84,7 @@ private function processStoreQuotes(StoreInterface $store): void
                         (string)$e
                     ));
                 }
-                if ($count % $batchSize === 0) {
+                if ($count % $this->batchSize === 0) {
                     $this->snapshot->clear($quote);
                 }
                 $quote->clearInstance();

app/code/Magento/Persistent/Test/Unit/Model/CleanExpiredPersistentQuotesTest.php

@@ -57,20 +57,24 @@ class CleanExpiredPersistentQuotesTest extends TestCase
      */
     private CleanExpiredPersistentQuotes $cleanExpiredPersistentQuotes;
 
+    private int $batchSize;
+
     protected function setUp(): void
     {
         $this->storeManagerMock = $this->createMock(StoreManagerInterface::class);
         $this->expiredPersistentQuotesCollectionMock = $this->createMock(ExpiredPersistentQuotesCollection::class);
         $this->quoteRepositoryMock = $this->createMock(QuoteRepository::class);
         $this->snapshotMock = $this->createMock(Snapshot::class);
         $this->loggerMock = $this->createMock(LoggerInterface::class);
+        $this->batchSize = 500;
 
         $this->cleanExpiredPersistentQuotes = new CleanExpiredPersistentQuotes(
             $this->storeManagerMock,
             $this->expiredPersistentQuotesCollectionMock,
             $this->quoteRepositoryMock,
             $this->snapshotMock,
-            $this->loggerMock
+            $this->loggerMock,
+            $this->batchSize
         );
     }
 

app/code/Magento/Persistent/etc/di.xml

@@ -25,4 +25,9 @@
     <type name="Magento\Quote\Model\QuoteManagement">
         <plugin name="persistent_convert_customer_cart_to_guest_cart" type="Magento\Persistent\Model\Plugin\ConvertCustomerCartToGuest" />
     </type>
+    <type name="Magento\Persistent\Model\CleanExpiredPersistentQuotes">
+        <arguments>
+            <argument name="batchSize" xsi:type="number">500</argument>
+        </arguments>
+    </type>
 </config>