Replaced string values with constants (#24726)

Author: zhartaunik

app/code/Magento/Catalog/Model/Product/Option.php

@@ -163,22 +163,22 @@ public function __construct(
         $this->customOptionValuesFactory = $customOptionValuesFactory ?:
             \Magento\Framework\App\ObjectManager::getInstance()->get(ProductCustomOptionValuesInterfaceFactory::class);
         $this->optionGroups = $optionGroups ?: [
-            'date' => Date::class,
-            'file' => File::class,
-            'select' => Select::class,
-            'text' => Text::class,
+            self::OPTION_GROUP_DATE => Date::class,
+            self::OPTION_GROUP_FILE => File::class,
+            self::OPTION_GROUP_SELECT => Select::class,
+            self::OPTION_GROUP_TEXT => Text::class,
         ];
         $this->optionGroupsToTypes = $optionGroupsToTypes ?: [
-            'field' => 'text',
-            'area' => 'text',
-            'file' => 'file',
-            'drop_down' => 'select',
-            'radio' => 'select',
-            'checkbox' => 'select',
-            'multiple' => 'select',
-            'date' => 'date',
-            'date_time' => 'date',
-            'time' => 'date',
+            self::OPTION_TYPE_FIELD => self::OPTION_GROUP_TEXT,
+            self::OPTION_TYPE_AREA => self::OPTION_GROUP_TEXT,
+            self::OPTION_TYPE_FILE => self::OPTION_GROUP_FILE,
+            self::OPTION_TYPE_DROP_DOWN => self::OPTION_GROUP_SELECT,
+            self::OPTION_TYPE_RADIO => self::OPTION_GROUP_SELECT,
+            self::OPTION_TYPE_CHECKBOX => self::OPTION_GROUP_SELECT,
+            self::OPTION_TYPE_MULTIPLE => self::OPTION_GROUP_SELECT,
+            self::OPTION_TYPE_DATE => self::OPTION_GROUP_DATE,
+            self::OPTION_TYPE_DATE_TIME => self::OPTION_GROUP_DATE,
+            self::OPTION_TYPE_TIME => self::OPTION_GROUP_DATE,
         ];
 
         parent::__construct(

app/code/Magento/Catalog/etc/di.xml

@@ -420,16 +420,16 @@
                 <item name="text" xsi:type="string">Magento\Catalog\Model\Product\Option\Type\Text</item>
             </argument>
             <argument name="optionGroupsToTypes" xsi:type="array">
-                <item name="field" xsi:type="string">text</item>
-                <item name="area" xsi:type="string">text</item>
-                <item name="file" xsi:type="string">file</item>
-                <item name="drop_down" xsi:type="string">select</item>
-                <item name="radio" xsi:type="string">select</item>
-                <item name="checkbox" xsi:type="string">select</item>
-                <item name="multiple" xsi:type="string">select</item>
-                <item name="date" xsi:type="string">date</item>
-                <item name="date_time" xsi:type="string">date</item>
-                <item name="time" xsi:type="string">date</item>
+                <item name="field" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_TEXT</item>
+                <item name="area" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_TEXT</item>
+                <item name="file" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_FILE</item>
+                <item name="drop_down" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_SELECT</item>
+                <item name="radio" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_SELECT</item>
+                <item name="checkbox" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_SELECT</item>
+                <item name="multiple" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_SELECT</item>
+                <item name="date" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_DATE</item>
+                <item name="date_time" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_DATE</item>
+                <item name="time" xsi:type="const">Magento\Catalog\Api\Data\ProductCustomOptionInterface::OPTION_GROUP_DATE</item>
             </argument>
         </arguments>
     </type>