MAGETWO-86239: Customer Address attribute value length is still validated when min/max length fields are not displayed at the backend

Author: Sergey Shvets

app/code/Magento/Eav/Test/Unit/Model/Attribute/Data/MultilineTest.php

@@ -3,8 +3,12 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Eav\Test\Unit\Model\Attribute\Data;
 
+use Magento\Framework\Locale\ResolverInterface;
+use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
+
 class MultilineTest extends \PHPUnit\Framework\TestCase
 {
     /**
@@ -13,15 +17,18 @@ class MultilineTest extends \PHPUnit\Framework\TestCase
     protected $model;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
+     * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Stdlib\StringUtils
      */
     protected $stringMock;
 
     protected function setUp()
     {
-        $timezoneMock = $this->createMock(\Magento\Framework\Stdlib\DateTime\TimezoneInterface::class);
+        /** @var \PHPUnit_Framework_MockObject_MockObject | TimezoneInterface $timezoneMock */
+        $timezoneMock = $this->createMock(TimezoneInterface::class);
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Psr\Log\LoggerInterface $loggerMock */
         $loggerMock = $this->createMock(\Psr\Log\LoggerInterface::class);
-        $localeResolverMock = $this->createMock(\Magento\Framework\Locale\ResolverInterface::class);
+        /** @var \PHPUnit_Framework_MockObject_MockObject | ResolverInterface $localeResolverMock */
+        $localeResolverMock = $this->createMock(ResolverInterface::class);
         $this->stringMock = $this->createMock(\Magento\Framework\Stdlib\StringUtils::class);
 
         $this->model = new \Magento\Eav\Model\Attribute\Data\Multiline(
@@ -33,19 +40,23 @@ protected function setUp()
     }
 
     /**
-     * @covers \Magento\Eav\Model\Attribute\Data\Multiline::extractValue
+     * @covers       \Magento\Eav\Model\Attribute\Data\Multiline::extractValue
      *
      * @param mixed $param
      * @param mixed $expectedResult
      * @dataProvider extractValueDataProvider
      */
     public function testExtractValue($param, $expectedResult)
     {
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\App\RequestInterface $requestMock */
         $requestMock = $this->createMock(\Magento\Framework\App\RequestInterface::class);
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Eav\Model\Attribute $attributeMock */
         $attributeMock = $this->createMock(\Magento\Eav\Model\Attribute::class);
 
         $requestMock->expects($this->once())->method('getParam')->will($this->returnValue($param));
-        $attributeMock->expects($this->once())->method('getAttributeCode')->will($this->returnValue('attributeCode'));
+        $attributeMock->expects($this->once())
+            ->method('getAttributeCode')
+            ->will($this->returnValue('attributeCode'));
 
         $this->model->setAttribute($attributeMock);
         $this->assertEquals($expectedResult, $this->model->extractValue($requestMock));
@@ -69,17 +80,21 @@ public function extractValueDataProvider()
     }
 
     /**
-     * @covers \Magento\Eav\Model\Attribute\Data\Multiline::outputValue
+     * @covers       \Magento\Eav\Model\Attribute\Data\Multiline::outputValue
      *
      * @param string $format
      * @param mixed $expectedResult
      * @dataProvider outputValueDataProvider
      */
     public function testOutputValue($format, $expectedResult)
     {
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Model\AbstractModel $entityMock */
         $entityMock = $this->createMock(\Magento\Framework\Model\AbstractModel::class);
-        $entityMock->expects($this->once())->method('getData')->will($this->returnValue("value1\nvalue2"));
+        $entityMock->expects($this->once())
+            ->method('getData')
+            ->will($this->returnValue("value1\nvalue2"));
 
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Eav\Model\Attribute $attributeMock */
         $attributeMock = $this->createMock(\Magento\Eav\Model\Attribute::class);
 
         $this->model->setEntity($entityMock);
@@ -113,8 +128,8 @@ public function outputValueDataProvider()
     }
 
     /**
-     * @covers \Magento\Eav\Model\Attribute\Data\Multiline::validateValue
-     * @covers \Magento\Eav\Model\Attribute\Data\Text::validateValue
+     * @covers       \Magento\Eav\Model\Attribute\Data\Multiline::validateValue
+     * @covers       \Magento\Eav\Model\Attribute\Data\Text::validateValue
      *
      * @param mixed $value
      * @param bool $isAttributeRequired
@@ -124,14 +139,23 @@ public function outputValueDataProvider()
      */
     public function testValidateValue($value, $isAttributeRequired, $rules, $expectedResult)
     {
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Model\AbstractModel $entityMock */
         $entityMock = $this->createMock(\Magento\Framework\Model\AbstractModel::class);
-        $entityMock->expects($this->any())->method('getDataUsingMethod')->will($this->returnValue("value1\nvalue2"));
+        $entityMock->expects($this->any())
+            ->method('getDataUsingMethod')
+            ->will($this->returnValue("value1\nvalue2"));
 
+        /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Eav\Model\Attribute $attributeMock */
         $attributeMock = $this->createMock(\Magento\Eav\Model\Attribute::class);
         $attributeMock->expects($this->any())->method('getMultilineCount')->will($this->returnValue(2));
         $attributeMock->expects($this->any())->method('getValidateRules')->will($this->returnValue($rules));
-        $attributeMock->expects($this->any())->method('getStoreLabel')->will($this->returnValue('Label'));
-        $attributeMock->expects($this->any())->method('getIsRequired')->will($this->returnValue($isAttributeRequired));
+        $attributeMock->expects($this->any())
+            ->method('getStoreLabel')
+            ->will($this->returnValue('Label'));
+
+        $attributeMock->expects($this->any())
+            ->method('getIsRequired')
+            ->will($this->returnValue($isAttributeRequired));
 
         $this->stringMock->expects($this->any())->method('strlen')->will($this->returnValue(5));
 
@@ -159,21 +183,21 @@ public function validateValueDataProvider()
                 'expectedResult' => true,
             ],
             [
-                'value' => ['value1',  'value2'],
+                'value' => ['value1', 'value2'],
                 'isAttributeRequired' => false,
                 'rules' => [],
                 'expectedResult' => true,
             ],
             [
                 'value' => 'value',
                 'isAttributeRequired' => false,
-                'rules' => ['max_text_length' => 3],
+                'rules' => ['input_validation' => 'other', 'max_text_length' => 3],
                 'expectedResult' => ['"Label" length must be equal or less than 3 characters.'],
             ],
             [
                 'value' => 'value',
                 'isAttributeRequired' => false,
-                'rules' => ['min_text_length' => 10],
+                'rules' => ['input_validation' => 'other', 'min_text_length' => 10],
                 'expectedResult' => ['"Label" length must be equal or greater than 10 characters.'],
             ],
             [