ENGCOM-1980: Adding support for variadic arguments fro method in generated proxy c… #16081

magento-engcom-team · magento-engcom-team · commit 2097c9b8c6f8 · 2018-06-13T06:57:18.000-05:00
- Merge Pull Request #16081 from vgelani/magento2:2.1-develop-PR-port-15177 - Merged commits: 1. 7091665
diff --git a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php
@@ -155,7 +155,8 @@ protected function _getMethodInfo(\ReflectionMethod $method)
         $parameterNames = [];
         $parameters = [];
         foreach ($method->getParameters() as $parameter) {
-            $parameterNames[] = '$' . $parameter->getName();
+            $name = $parameter->isVariadic() ? '... $' . $parameter->getName() : '$' . $parameter->getName();
+            $parameterNames[] = $name;
             $parameters[] = $this->_getMethodParameterInfo($parameter);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,8 @@ protected function _getMethodInfo(\ReflectionMethod $method)`
`155`	`155`	`$parameterNames = [];`
`156`	`156`	`$parameters = [];`
`157`	`157`	`foreach ($method->getParameters() as $parameter) {`
`158`		`- $parameterNames[] = '$' . $parameter->getName();`
	`158`	`+ $name = $parameter->isVariadic() ? '... $' . $parameter->getName() : '$' . $parameter->getName();`
	`159`	`+ $parameterNames[] = $name;`
`159`	`160`	`$parameters[] = $this->_getMethodParameterInfo($parameter);`
`160`	`161`	`}`
`161`	`162`