remove unwanted condition check

Dominic · Dominic · commit 1fde48643e8a · 2019-02-07T21:54:51.000+05:30
diff --git a/app/code/Magento/Cms/Helper/Page.php b/app/code/Magento/Cms/Helper/Page.php
@@ -180,14 +180,15 @@ public function prepareResultPage(Action $action, $pageId = null)
     /**
      * Retrieve page direct URL
      *
-     * @param string $pageId
-     * @return string
+     * @param null $pageId
+     * @return string|null
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
     public function getPageUrl($pageId = null)
     {
         /** @var \Magento\Cms\Model\Page $page */
         $page = $this->_pageFactory->create();
-        if ($pageId !== null && $pageId !== $page->getId()) {
+        if ($pageId !== null) {
             $page->setStoreId($this->_storeManager->getStore()->getId());
             $page->load($pageId);
         }

Original file line number	Diff line number	Diff line change
`@@ -180,14 +180,15 @@ public function prepareResultPage(Action $action, $pageId = null)`
`180`	`180`	`/**`
`181`	`181`	`* Retrieve page direct URL`
`182`	`182`	`*`
`183`		`- * @param string $pageId`
`184`		`- * @return string`
	`183`	`+ * @param null $pageId`
	`184`	`+ * @return string\|null`
	`185`	`+ * @throws \Magento\Framework\Exception\NoSuchEntityException`
`185`	`186`	`*/`
`186`	`187`	`public function getPageUrl($pageId = null)`
`187`	`188`	`{`
`188`	`189`	`/** @var \Magento\Cms\Model\Page $page */`
`189`	`190`	`$page = $this->_pageFactory->create();`
`190`		`- if ($pageId !== null && $pageId !== $page->getId()) {`
	`191`	`+ if ($pageId !== null) {`
`191`	`192`	`$page->setStoreId($this->_storeManager->getStore()->getId());`
`192`	`193`	`$page->load($pageId);`
`193`	`194`	`}`