Skip to content

Commit 1fcf058

Browse files
author
Cari Spruiell
committed
MAGETWO-38060: Fix test coverage builds
- fixed static build failures
1 parent 71c8ec5 commit 1fcf058

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

app/code/Magento/Integration/Model/Config/Integration/Reader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
/**
99
* Service config data reader.
10-
10+
*
1111
* @codeCoverageIgnore
1212
*/
1313
class Reader extends \Magento\Framework\Config\Reader\Filesystem

app/code/Magento/Integration/Model/Oauth/Consumer/Validator/KeyLength.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ class KeyLength extends \Zend_Validate_StringLength
2020
/**
2121
* @var array
2222
*/
23-
protected $_messageTemplates = array(
23+
protected $_messageTemplates = [
2424
self::INVALID => "Invalid type given for %name%. String expected",
2525
self::TOO_SHORT => "%name% '%value%' is less than %min% characters long",
2626
self::TOO_LONG => "%name% '%value%' is more than %max% characters long",
27-
);
27+
];
2828

2929
/**
3030
* Additional variables available for validation failure messages

app/code/Magento/Integration/Test/Unit/Model/Oauth/Token/ProviderTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,6 @@ public function testValidateRequestTokenInvalidVerifier()
360360
$oauthVerifier = 1;
361361
$consumerId = 1;
362362
$tokenId = 1;
363-
$secret = 'secret';
364363

365364
$this->requestTokenMock->expects($this->once())
366365
->method('load')
@@ -416,7 +415,6 @@ public function testValidateRequestTokenNotMatchedVerifier()
416415
$notMatchedVerifier = '123';
417416
$consumerId = 1;
418417
$tokenId = 1;
419-
$secret = 'secret';
420418

421419
$this->requestTokenMock->expects($this->once())
422420
->method('load')
@@ -608,7 +606,7 @@ public function testValidateAccessToken()
608606
$this->consumerMock->expects($this->any())->method('getId')->willReturn($consumerId);
609607

610608
$this->accessTokenMock->expects($this->once())->method('getType')->willReturn(Token::TYPE_ACCESS);
611-
$this->accessTokenMock->expects($this->once())->method('getRevoked')->willReturn(0);;
609+
$this->accessTokenMock->expects($this->once())->method('getRevoked')->willReturn(0);
612610
$this->assertEquals(
613611
$consumerId,
614612
$this->tokenProvider->validateAccessToken($accessTokenString)

app/code/Magento/Integration/Test/Unit/Model/Oauth/TokenTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
use Magento\Authorization\Model\UserContextInterface;
1313
use Magento\Framework\TestFramework\Unit\Matcher\MethodInvokedAtIndex;
1414

15-
1615
/**
1716
* Unit test for \Magento\Integration\Model\Oauth\Nonce
1817
*/
@@ -209,8 +208,8 @@ public function testCreateVerifierTokenIfNoTokenId()
209208
$verifier = 'verifier';
210209

211210
$this->oauthHelperMock->expects($this->once())->method('generateTokenSecret')->willReturn($secret);
212-
$this->oauthHelperMock->expects($this->once())->method('generateToken')->willReturn($token);;
213-
$this->oauthHelperMock->expects($this->once())->method('generateVerifier')->willReturn($verifier);;
211+
$this->oauthHelperMock->expects($this->once())->method('generateToken')->willReturn($token);
212+
$this->oauthHelperMock->expects($this->once())->method('generateVerifier')->willReturn($verifier);
214213

215214
$this->resourceMock->expects($this->once())
216215
->method('selectTokenByType')
@@ -301,7 +300,7 @@ public function testCreateRequestToken()
301300
$secret = 'secret';
302301

303302
$this->oauthHelperMock->expects($this->once())->method('generateTokenSecret')->willReturn($secret);
304-
$this->oauthHelperMock->expects($this->once())->method('generateToken')->willReturn($token);;
303+
$this->oauthHelperMock->expects($this->once())->method('generateToken')->willReturn($token);
305304

306305
$this->tokenModel->setCallbackUrl($callbackUrl);
307306
$this->keyLengthFactoryMock->expects($this->once())->method('create')->willReturn(

0 commit comments

Comments
 (0)