MC-20212: [On premise] Data loss due to core cron job called sales_clean_quotes

- small refactor

Author: Oleksandr Dubovyk

app/code/Magento/Sales/Cron/CleanExpiredQuotes.php

@@ -6,7 +6,7 @@
 namespace Magento\Sales\Cron;
 
 use Magento\Quote\Model\ResourceModel\Quote\Collection;
-use Magento\Sales\Helper\ExpiredQuotesCollection;
+use Magento\Sales\Model\ResourceModel\ExpiredQuotesCollection;
 use Magento\Store\Model\StoreManagerInterface;
 
 /**

app/code/Magento/Sales/Helper/ExpiredQuotesCollection.php renamed to app/code/Magento/Sales/Model/ResourceModel/Collection/ExpiredQuotesCollection.php

@@ -16,18 +16,20 @@
  */
 class ExpiredQuotesCollection
 {
-    const SECONDS_IN_DAY = 86400;
-    const QUOTE_LIFETIME = 'checkout/cart/delete_quote_after';
+    /**
+     * @var int
+     */
+    private $secondsInDay = 86400;
 
     /**
-     * @var CollectionFactory
+     * @var string
      */
-    private $quoteCollectionFactory;
+    private $quoteLifetime = 'checkout/cart/delete_quote_after';
 
     /**
-     * @var array
+     * @var CollectionFactory
      */
-    private $expireQuotesFilterFields = [];
+    private $quoteCollectionFactory;
 
     /**
      * @var ScopeConfigInterface
@@ -58,42 +60,17 @@ public function __construct(
     public function getExpiredQuotes(StoreInterface $store)
     {
         $lifetime = $this->config->getValue(
-            self::QUOTE_LIFETIME,
+            $this->quoteLifetime,
             ScopeInterface::SCOPE_STORE,
             $store->getCode()
         );
-        $lifetime *= self::SECONDS_IN_DAY;
+        $lifetime *= $this->secondsInDay;
 
         /** @var $quotes Collection */
         $quotes = $this->quoteCollectionFactory->create();
         $quotes->addFieldToFilter('store_id', $store->getId());
         $quotes->addFieldToFilter('updated_at', ['to' => date("Y-m-d", time() - $lifetime)]);
 
-        foreach ($this->getExpireQuotesAdditionalFilterFields() as $field => $condition) {
-            $quotes->addFieldToFilter($field, $condition);
-        }
-
         return $quotes;
     }
-
-    /**
-     * Retrieve expire quotes additional fields to filter
-     *
-     * @return array
-     */
-    private function getExpireQuotesAdditionalFilterFields()
-    {
-        return $this->expireQuotesFilterFields;
-    }
-
-    /**
-     * Set expire quotes additional fields to filter
-     *
-     * @param array $fields
-     * @return void
-     */
-    public function setExpireQuotesAdditionalFilterFields(array $fields)
-    {
-        $this->expireQuotesFilterFields = $fields;
-    }
 }