Skip to content

Commit 1f3306c

Browse files
committed
MC-20075: Fix Skipped MFTF Tests From MC-17140: MC-14536, MC-14538, MC-14720
1 parent 1814e32 commit 1f3306c

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontCheckCartDiscountAndSummaryActionGroup.xml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,12 @@
1717
<argument name="total" type="string"/>
1818
<argument name="discount" type="string"/>
1919
</arguments>
20-
2120
<waitForPageLoad stepKey="waitForPageLoad"/>
22-
<waitForLoadingMaskToDisappear stepKey="waitForPrices"/>
21+
<waitForElement time="30" selector="{{CheckoutCartSummarySection.estimateShippingAndTaxForm}}" stepKey="waitForEstimateShippingAndTaxForm"/>
22+
<waitForElement time="30" selector="{{CheckoutCartSummarySection.shippingMethodForm}}" stepKey="waitForShippingMethodForm"/>
23+
<waitForElementVisible time="30" selector="{{CheckoutCartSummarySection.total}}" stepKey="waitForTotalElement"/>
24+
<see selector="{{CheckoutCartSummarySection.total}}" userInput="${{total}}" stepKey="assertTotal"/>
25+
<waitForElementVisible selector="{{CheckoutCartSummarySection.discountAmount}}" stepKey="waitForDiscountElement"/>
2326
<see selector="{{CheckoutCartSummarySection.discountAmount}}" userInput="-${{discount}}" stepKey="assertDiscount"/>
24-
<wait time="10" stepKey="waitForTotalPrice"/>
25-
<reloadPage stepKey="reloadPage" after="waitForTotalPrice" />
26-
<waitForPageLoad after="reloadPage" stepKey="WaitForPageLoaded" />
27-
<see selector="{{CheckoutCartSummarySection.total}}" userInput="${{total}}" stepKey="assertTotal" after="WaitForPageLoaded"/>
2827
</actionGroup>
2928
</actionGroups>

app/code/Magento/Checkout/Test/Mftf/Section/CheckoutCartSummarySection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,6 @@
3333
<element name="methodName" type="text" selector="#co-shipping-method-form label"/>
3434
<element name="shippingPrice" type="text" selector="#co-shipping-method-form span .price"/>
3535
<element name="shippingMethodElementId" type="radio" selector="#s_method_{{carrierCode}}_{{methodCode}}" parameterized="true"/>
36+
<element name="estimateShippingAndTaxForm" type="block" selector="#shipping-zip-form"/>
3637
</section>
3738
</sections>

app/code/Magento/SalesRule/Test/Mftf/ActionGroup/AdminDeleteCartPriceRuleActionGroup.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@
1818

1919
<amOnPage url="{{AdminCartPriceRulesPage.url}}" stepKey="goToCartPriceRules"/>
2020
<waitForPageLoad stepKey="waitForCartPriceRules"/>
21-
<click selector="{{AdminCartPriceRulesFormSection.resetSearchFilter}}" stepKey="resetFilterBeforeDelete"/>
21+
<click selector="{{AdminDataGridHeaderSection.clearFilters}}" stepKey="resetFilterBeforeDelete"/>
2222
<waitForPageLoad stepKey="waitForCartPriceRulesResetFilter"/>
2323
<fillField selector="{{AdminCartPriceRulesSection.filterByNameInput}}" userInput="{{ruleName.name}}" stepKey="filterByName"/>
2424
<click selector="{{AdminCartPriceRulesSection.searchButton}}" stepKey="doFilter"/>
2525
<click selector="{{AdminCartPriceRulesSection.rowByIndex('1')}}" stepKey="goToEditRulePage"/>
2626
<click selector="{{AdminCartPriceRulesFormSection.delete}}" stepKey="clickDeleteButton"/>
27-
<click selector="{{AdminCartPriceRulesFormSection.modalAcceptButton}}" stepKey="confirmDelete"/>
28-
<click selector="{{AdminCartPriceRulesFormSection.resetSearchFilter}}" stepKey="resetFilterAfterDelete"/>
29-
<waitForPageLoad stepKey="waitForCartPriceRulesAfterDelete"/>
27+
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForConfirmModal"/>
28+
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="confirmDelete"/>
3029
</actionGroup>
3130
</actionGroups>

0 commit comments

Comments
 (0)