🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #14301: Fixed TypeError when search term does not exist on pressing Home or End button #14274 (by @drashmk)
 - #14305: [Forward Port] [#14089] Add Malaysian Locale Code (by @osrecio)
 - #14300: [ForwardPort 2.3] [#14072] Add Zip Pattern for Japan JP (by @osrecio)


Fixed GitHub Issues:
 - #14274: Quick search fires error (reported by @jonathanKingston) has been fixed in #14301 by @drashmk in 2.3-develop branch
   Related commits:
     1. bd47df7
     2. 98be34b
     3. a5252de

 - #14089: Malaysian (Malaysia) missing from locale list (reported by @superdav42) has been fixed in #14305 by @osrecio in 2.3-develop branch
   Related commits:
     1. 7081c47
     2. 7df2162

 - #14072: Change zip code validation pattern for Japan (reported by @HirokazuNishi) has been fixed in #14300 by @osrecio in 2.3-develop branch
   Related commits:
     1. 79474ca
     2. 1e735aa

Author: magento-engcom-team

app/code/Magento/Directory/etc/zip_codes.xml

@@ -207,7 +207,7 @@
     <zip countryCode="JP">
         <codes>
             <code id="pattern_1" active="true" example="123-4567">^[0-9]{3}-[0-9]{4}$</code>
-            <code id="pattern_2" active="true" example="123">^[0-9]{3}$</code>
+            <code id="pattern_2" active="true" example="1234567">^[0-9]{7}$</code>
         </codes>
     </zip>
     <zip countryCode="JE">

app/code/Magento/Search/view/frontend/web/form-mini.js

@@ -206,13 +206,17 @@ define([
 
             switch (keyCode) {
                 case $.ui.keyCode.HOME:
-                    this._getFirstVisibleElement().addClass(this.options.selectClass);
-                    this.responseList.selected = this._getFirstVisibleElement();
+                    if (this._getFirstVisibleElement()) {
+                        this._getFirstVisibleElement().addClass(this.options.selectClass);
+                        this.responseList.selected = this._getFirstVisibleElement();
+                    }
                     break;
 
                 case $.ui.keyCode.END:
-                    this._getLastElement().addClass(this.options.selectClass);
-                    this.responseList.selected = this._getLastElement();
+                    if (this._getLastElement()) {
+                        this._getLastElement().addClass(this.options.selectClass);
+                        this.responseList.selected = this._getLastElement();
+                    }
                     break;
 
                 case $.ui.keyCode.ESCAPE:

dev/tests/integration/testsuite/Magento/Directory/Model/Country/Postcode/ValidatorTest.php

@@ -133,7 +133,7 @@ public function getPostcodesDataProvider()
             ['countryId' => 'IL', 'postcode' => '12345'],
             ['countryId' => 'IT', 'postcode' => '12345'],
             ['countryId' => 'JP', 'postcode' => '123-4567'],
-            ['countryId' => 'JP', 'postcode' => '123'],
+            ['countryId' => 'JP', 'postcode' => '1234567'],
             ['countryId' => 'JE', 'postcode' => 'TY8 9PL'],
             ['countryId' => 'KZ', 'postcode' => '123456'],
             ['countryId' => 'KE', 'postcode' => '12345'],

lib/internal/Magento/Framework/Locale/Config.php

@@ -74,6 +74,7 @@ class Config implements \Magento\Framework\Locale\ConfigInterface
         'lv_LV', /*Latvian (Latvia)*/
         'mk_MK', /*Macedonian (Macedonia)*/
         'mn_Cyrl_MN', /*Mongolian (Mongolia)*/
+        'ms_MY', /*Malaysian (Malaysia)*/
         'ms_Latn_MY', /*Malaysian (Malaysia)*/
         'nl_BE', /*Dutch (Belgium)*/
         'nl_NL', /*Dutch (Netherlands)*/