magento/async-import#102: Fixed code style issues

Author: Stanislav Idolov

app/code/Magento/AmqpStore/Plugin/AsynchronousOperations/MassConsumerEnvelopeCallback.php

@@ -63,8 +63,11 @@ public function __construct(
      * @return void
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function aroundExecute(SubjectMassConsumerEnvelopeCallback $subject, callable $proceed, EnvelopeInterface $message)
-    {
+    public function aroundExecute(
+        SubjectMassConsumerEnvelopeCallback $subject,
+        callable $proceed,
+        EnvelopeInterface $message
+    ) {
         $amqpProperties = $message->getProperties();
         if (isset($amqpProperties['application_headers'])) {
             $headers = $amqpProperties['application_headers'];

app/code/Magento/AmqpStore/Plugin/Framework/Amqp/Bulk/Exchange.php

@@ -39,8 +39,10 @@ class Exchange
     private $logger;
 
     /**
+     * Exchange constructor.
      * @param EnvelopeFactory $envelopeFactory
      * @param StoreManagerInterface $storeManager
+     * @param LoggerInterface $logger
      */
     public function __construct(
         EnvelopeFactory $envelopeFactory,
@@ -89,6 +91,7 @@ public function beforeEnqueue(SubjectExchange $subject, $topic, array $envelopes
                 if ($headers instanceof AMQPTable) {
                     try {
                         $headers->set('store_id', $storeId);
+                    // phpcs:ignore Magento2.Exceptions.ThrowCatch
                     } catch (AMQPInvalidArgumentException $ea) {
                         $errorMessage = sprintf("Can't set storeId to amqp message. Error %s.", $ea->getMessage());
                         $this->logger->error($errorMessage);

app/code/Magento/AsynchronousOperations/Model/MassConsumer.php

@@ -89,10 +89,12 @@ public function process($maxNumberOfMessages = null)
      */
     private function getTransactionCallback(QueueInterface $queue)
     {
-        $callbackInstance =  $this->massConsumerEnvelopeCallback->create([
-            'configuration' => $this->configuration,
-            'queue' => $queue,
-        ]);
+        $callbackInstance =  $this->massConsumerEnvelopeCallback->create(
+            [
+                'configuration' => $this->configuration,
+                'queue' => $queue,
+            ]
+        );
         return function (EnvelopeInterface $message) use ($callbackInstance) {
             $callbackInstance->execute($message);
         };

app/code/Magento/AsynchronousOperations/Model/MassConsumerEnvelopeCallback.php

@@ -74,9 +74,11 @@ public function __construct(
         $this->resource = $resource;
         $this->messageController = $messageController;
         $this->configuration = $configuration;
-        $this->operationProcessor = $operationProcessorFactory->create([
-            'configuration' => $configuration
-        ]);
+        $this->operationProcessor = $operationProcessorFactory->create(
+            [
+                'configuration' => $configuration
+            ]
+        );
         $this->logger = $logger;
         $this->queue = $queue;
     }
@@ -125,6 +127,7 @@ public function execute(EnvelopeInterface $message)
 
     /**
      * Get message queue.
+     *
      * @return QueueInterface
      */
     public function getQueue()

dev/tests/api-functional/testsuite/Magento/WebapiAsync/Model/AsyncScheduleMultiStoreTest.php

@@ -99,11 +99,14 @@ protected function setUp()
         );
 
         /** @var PublisherConsumerController publisherConsumerController */
-        $this->publisherConsumerController = $this->objectManager->create(PublisherConsumerController::class, [
-            'consumers' => $this->consumers,
-            'logFilePath' => $this->logFilePath,
-            'appInitParams' => $params,
-        ]);
+        $this->publisherConsumerController = $this->objectManager->create(
+            PublisherConsumerController::class,
+            [
+                'consumers' => $this->consumers,
+                'logFilePath' => $this->logFilePath,
+                'appInitParams' => $params,
+            ]
+        );
         $this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
 
         try {
@@ -240,6 +243,7 @@ private function clearProducts()
             foreach ($this->skus as $sku) {
                 $this->productRepository->deleteById($sku);
             }
+        // phpcs:ignore Magento2.Exceptions.ThrowCatch
         } catch (\Exception $e) {
             throw $e;
             //nothing to delete
@@ -252,6 +256,7 @@ private function clearProducts()
             ->getSize();
 
         if ($size > 0) {
+            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new Exception(new Phrase("Collection size after clearing the products: %size", ['size' => $size]));
         }
         $this->skus = [];
@@ -271,11 +276,13 @@ public function getProductData()
 
         return [
             'product' =>
-                $productBuilder([
-                    ProductInterface::TYPE_ID => 'simple',
-                    ProductInterface::SKU => 'multistore-sku-test-1',
-                    ProductInterface::NAME => 'Test Name ',
-                ]),
+                $productBuilder(
+                    [
+                        ProductInterface::TYPE_ID => 'simple',
+                        ProductInterface::SKU => 'multistore-sku-test-1',
+                        ProductInterface::NAME => 'Test Name ',
+                    ]
+                ),
         ];
     }
 
@@ -341,10 +348,12 @@ public function assertProductCreation($product)
 
     /**
      * Remove test store
+     * //phpcs:disable
      */
     public static function tearDownAfterClass()
     {
         parent::tearDownAfterClass();
+        //phpcs:enable
         /** @var Registry $registry */
         $registry = Bootstrap::getObjectManager()->get(Registry::class);