Skip to content

Commit 1dcbd54

Browse files
author
Victor Rad
committed
MAGETWO-36951: Decrease CRAP of Magento\Review\Model\Resource\Review::aggregate
- CR fix
1 parent 4312881 commit 1dcbd54

File tree

2 files changed

+5
-5
lines changed
  • app/code/Magento/Review/Model/Resource
  • dev/tests/integration/testsuite/Magento/Review/Model/Resource/Review

2 files changed

+5
-5
lines changed

app/code/Magento/Review/Model/Resource/Review.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public function aggregate($object)
338338
* Aggregate review summary
339339
*
340340
* @param \Magento\Framework\Model\AbstractModel $object
341-
* @param \Magento\Framework\Data\Collection\Db $ratingSummaryObject
341+
* @param \Magento\Review\Model\Rating $ratingSummaryObject
342342
* @return void
343343
*/
344344
protected function aggregateReviewSummary($object, $ratingSummaryObject)

dev/tests/integration/testsuite/Magento/Review/Model/Resource/Review/ReviewTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ class ReviewTest extends \PHPUnit_Framework_TestCase
2121
protected $reviewResource;
2222

2323
/**
24-
* @var \Magento\Review\Model\Review
24+
* @var \Magento\Review\Model\Resource\Review\Collection
2525
*/
26-
protected $review;
26+
protected $reviewCollection;
2727

2828
/**
2929
* @var \Magento\Framework\App\Resource
@@ -43,7 +43,7 @@ protected function setUp()
4343
$this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
4444
$this->resource = $this->objectManager->get('Magento\Framework\App\Resource');
4545
$this->adapter = $this->resource->getConnection('core_read');
46-
$this->review = $this->objectManager->create('Magento\Review\Model\Review');
46+
$this->reviewCollection = $this->objectManager->create('Magento\Review\Model\Resource\Review\Collection');
4747
$this->reviewResource = $this->objectManager->create('Magento\Review\Model\Resource\Review');
4848
}
4949

@@ -52,7 +52,7 @@ protected function setUp()
5252
*/
5353
public function testAggregate()
5454
{
55-
$rating = $this->review->getCollection()->getFirstItem();
55+
$rating = $this->reviewCollection->getFirstItem();
5656
$this->reviewResource->aggregate($rating);
5757

5858
$select = $this->adapter->select()->from($this->resource->getTableName('review_entity_summary'));

0 commit comments

Comments
 (0)