GraphQL-408: mutations add<Product Type>ProductsToCart dosn't check if the cart is active

Author: naydav

app/code/Magento/QuoteGraphQl/Model/Cart/GetCartForUser.php

@@ -69,9 +69,9 @@ public function execute(string $cartHash, ?int $customerId): Quote
             );
         }
 
-        if (!$cart->getIsActive()) {
+        if (false === (bool)$cart->getIsActive()) {
             throw new GraphQlNoSuchEntityException(
-                __('Current customer does not have an active cart.')
+                __('Current user does not have an active cart.')
             );
         }
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartTest.php

@@ -118,7 +118,7 @@ public function testGetNonExistentCart()
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      * @expectedException \Exception
-     * @expectedExceptionMessage Current customer does not have an active cart.
+     * @expectedExceptionMessage Current user does not have an active cart.
      */
     public function testGetInactiveCart()
     {
@@ -127,7 +127,7 @@ public function testGetInactiveCart()
         $quote->setCustomerId(1);
         $quote->setIsActive(false);
         $this->quoteResource->save($quote);
-        $maskedQuoteId =  $this->quoteIdToMaskedId->execute((int)$quote->getId());
+        $maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$quote->getId());
 
         $query = $this->getCartQuery($maskedQuoteId);
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetCartTest.php

@@ -97,6 +97,24 @@ public function testGetNonExistentCart()
         $this->graphQlQuery($query);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
+     * @expectedException \Exception
+     * @expectedExceptionMessage Current user does not have an active cart.
+     */
+    public function testGetInactiveCart()
+    {
+        $quote = $this->quoteFactory->create();
+        $this->quoteResource->load($quote, 'test_order_with_simple_product_without_address', 'reserved_order_id');
+        $quote->setIsActive(false);
+        $this->quoteResource->save($quote);
+        $maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$quote->getId());
+
+        $query = $this->getCartQuery($maskedQuoteId);
+
+        $this->graphQlQuery($query);
+    }
+
     /**
      * @param string $maskedQuoteId
      * @return string